Page MenuHomePhabricator

AltGr key no longer works when editing text in translations (on Meta with 1.23wmf9)
Closed, DeclinedPublic

Description

The AltGr key of native keyboards no longer works. This is a severe bug with MANY international keyboards.

It is now intepreted as if we pressed Alt for inserting $placeholders.

For example it i impossible to enter the following basic ASCII characters on a standard French keyboard :

  1. { [ | ` \ @ ] }

as well as the following symbols :

¤ €

and some accents. Many extended keyboards using AltGr (or Ctrl+Alt) for entering some other characters are also unusable.

This is a severe regression of functionality when the recent addition facility for Alt+1 (which was not working anyway, but not dramatic) is clearly optional.

Most languages (except English which does not need translations most of the time) are affected.

Please revert this change (bug seen when translating on Meta)


Version: unspecified
Severity: major
Whiteboard: aklapper-moreinfo
URL: https://meta.wikimedia.org/wiki/Special:LanguageStats

Details

Reference
bz59890

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:34 AM
bzimport set Reference to bz59890.
bzimport added a subscriber: Unknown Object (MLST).

Note: this bug is critical.

It is caused by a recent change in code which has been deployed WITHOUT having been tested at all !!!

Can you please provide exact steps to reproduce? That includes a URL so we can verify that this issue hasn't already resolved. (ref https://gerrit.wikimedia.org/r/#/c/104934 ).

  • Just visit Meta
  • select any kind of translation from the navigation bar or on pages proposing translations.
  • select any item to translate
  • try pressing AltGr+3 to enter # on a French keyboard : does not work, it inserts the 3rd $placeholder proposed (if there's one)
  • using AltGr+E to generate €
  • try any other non-US keyboards mapping characters on the 1st row with digits, or on any row (e.g. UK keyboard with AltGr+4 for the €

All translations are affected

Note: I'm using Chrome on Windows. But I get the same with IE or Firefox.

In my opinion the code recently deployed on Meta is wrong. Clearing the browser cache did not work.

Also there was no problems a few days ago.

(In reply to comment #3)

  • Just visit Meta
  • select any kind of translation from the navigation bar or on pages proposing translations.
  • select any item to translate
  • try pressing AltGr+3 to enter # on a French keyboard : does not work, it inserts the 3rd $placeholder proposed (if there's one)

Can you please try to reproduce on medawiki.org? That's is running 1.23wmf10 and may display different behavior. As noted before, this is most likely related to https://gerrit.wikimedia.org/r/#/c/104934.

Also why did you remove the regresion tag ? It is a regression at least on Meta. I've not checked other wiki sites.

The patch given in Gerrit is not in the javascript used on Meta, or may be there was a deployement problem or the untested code was deployed too early on Meta without the patch.

Meta currently runs 1.23wmf9 (f7f4596)

The patch works on Mediawiki.org.
Meta has now the bug.

Philippe: Is this still an issue? I'd expect Meta to work nowadays if mw.org worked already at the time of testing. And if Meta does not work, this must be something specific about Meta and likely not in Translate code.

I no longer see the issue. My keyboard layout with many characters composed with AltGr (or Right-Alt + Ctrl), possibly also combined with Shift, works correctly.

They are no longer confused by shortcuts using (Left-)Alt, including those shortcuts on the first row (with digits).

In summary, you can close this issue which was only related to the missing deployment of a corrected version on Meta. For me it's FIXED