Maniphest T61928

Flow: If blocked, the user has no Reply buttons
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Quiddity
	Jan 10 2014, 11:15 PM

Description

As a blocked user, there are no Reply buttons at all, so I cannot find any error message, Nor any explanation of why the Reply buttons do not appear.

Performance question (see comment): Should we be checking blocked status at view time? We could check via AJAX when they click into the field, but if the perf is not that bad, we might not need to worry about it.

A blocked user can't edit its page but leave a message on the page is the way to appeal from a block.

See also bug T61927: Flow: Improve the blocked-user error message

Screenshot_from_2014-01-10_15:04:37.png (918×991 px, 145 KB)

Details

Reference: bz59928

Related Objects

Mentioned In: T232696: Block prevents replying to Flow threads
T219050: Revoking talk page access for anons doesn't work
T108762: Notify users who are editing protected flow content
Mentioned Here: T61927: Flow: Improve the blocked-user error message

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:37 AM

• bzimport added a project: StructuredDiscussions.

• bzimport set Reference to bz59928.

• bzimport added a subscriber: Unknown Object (MLST).

Quiddity created this task.Jan 10 2014, 11:15 PM

bingle-admin wrote:

The WMF core features team tracks this bug on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/flow/cards/711, but people from the community are welcome to contribute here and in Gerrit.

No longer true.

My mistake. It's true for logged-in users, just not for IP users.

Quiddity added a project: Collaboration-Team-Triage.Oct 28 2015, 1:39 AM

Quiddity removed a subscriber: • DannyH.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 28 2015, 1:39 AM

Hwangjy9 subscribed.Jan 19 2016, 2:03 PM

revi subscribed.Jan 19 2016, 4:03 PM

UX-aside (which indeed is unintuitive), should we be checking this before they save?

Core:

checkUserBlock, indirectly called from userCan and quickUserCan
- SkinTemplate calls it with quickUserCan (rigor 'quick'), which means it gets skipped.
- When you visit the edit page (but before you save it), it uses rigor 'full', which means it does check the block status, but from a slave (it is checked from master on save).
Flow checks (from a slave) to generate the list of actions, which happens on every visit to the talk page.

I'm not sure if this is right, or not. Flow doesn't really have the same concept of edit page and I'm not sure how serious the performance issue is. Flow deals with Varnish poisoning by not checking either blocked status or quickUserCan for anons (since one anon being blocked does not mean "user is blocked" should be cached in Varnish). It seems like it should still check quickUserCan, though, so I'll change that to start with.

• Mattflaschen-WMF edited projects, added Collab-Team-2016-Apr-Jun-Q4; removed Collaboration-Team-Triage.Apr 1 2016, 9:25 PM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 1 2016, 9:25 PM

• Mattflaschen-WMF removed a project: Collaboration-Team-Triage.Apr 1 2016, 9:26 PM

• Mattflaschen-WMF updated the task description. (Show Details)

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 1 2016, 9:26 PM

• Mattflaschen-WMF updated the task description. (Show Details)Apr 1 2016, 9:27 PM

• Mattflaschen-WMF mentioned this in T108762: Notify users who are editing protected flow content.

Catrope moved this task from Untriaged to Ready for Pickup on the Collab-Team-2016-Apr-Jun-Q4 board.Apr 3 2016, 9:07 AM

• jmatazzoni removed a project: Collaboration-Team-Triage.Apr 19 2016, 6:10 PM

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 6:10 PM

• jmatazzoni edited projects, added Collaboration-Team-Triage; removed Collab-Team-2016-Apr-Jun-Q4.May 9 2016, 9:30 PM

Mentioned on IRC: a block user can't edit their talk page. Which is problematic a bit when you are supposed to edit this page to appeal from the blockage.

Trizek-WMF updated the task description. (Show Details)Jun 14 2017, 1:29 PM

Trizek-WMF moved this task from Backlog to History Structured Discussions on the StructuredDiscussions board.

Ash_Crow subscribed.Jun 14 2017, 1:31 PM

Thibaut120094 subscribed.Jun 14 2017, 1:42 PM

EBernhardson unsubscribed.Jul 18 2018, 7:01 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 18 2018, 7:01 PM

SBisson moved this task from Inbox to Triaged but Future on the Growth-Team board.Jul 20 2018, 6:06 PM

Lens0021 subscribed.Sep 28 2018, 1:33 AM

TheVoidwalker mentioned this in T219050: Revoking talk page access for anons doesn't work.Mar 23 2019, 2:58 AM

Lens0021 mentioned this in T232696: Block prevents replying to Flow threads.Sep 12 2019, 5:57 AM

revi merged a task: T232696: Block prevents replying to Flow threads.Sep 17 2019, 3:22 AM

revi added subscribers: Jasper, MGChecker, JJMC89.