Page MenuHomePhabricator

Add number of "Automatically enable all new beta features" users on Special:Preferences (as tooltip?)
Open, LowPublicFeature

Description

All others preferences for BetaFeatures have a number about the user which use that, but this has not, please add. Thanks.


Version: REL1_22-branch
Severity: enhancement

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:39 AM
bzimport set Reference to bz59955.
bzimport added a subscriber: Unknown Object (MLST).

I believe this number is stored, so it should be trivial to expose. It's mostly a design question. Jared: thoughts?

Maybe as a tooltip, but otherwise i think it unnecessarily clutters the UI, and would make the text for the action harder to parse for people.

anboia wrote:

this number it is not stored. this extension have a betafeatures_user_counts table that store the number of users of some extensions used... but there is no default row for store the "Automatically enable all new beta features" users number. so I believe that will be needed to add a default row in the sql scrept, to store this number.

Honestly it's probably specifically *excepted* from the query that updates the rows, so you could probably add it in pretty quickly.

If not, adding another value also shouldn't be too hard.

You don't need to add a row, it will be possible to do this without changing the schema, you just need to add another criterion ("OR feature_name = betafeatures-auto-enroll" or something) that will also add the list for this, then surface that number in the UI.

And maybe add a cache for it.

Change 110238 had a related patch set uploaded by Mno2:
BetaFeatures: Show number of users who enabled auto-enroll option

https://gerrit.wikimedia.org/r/110238

anboia wrote:

I and a team that I am working with, are learning how to contribute with the MediaWiki, and this maybe will be our first contribution :D.

So we just have submitted the patch gerrit change 110238, and the basic idea is that we added:

$wgHooks['GetBetaFeaturePreferences'][] = BetaFeaturesHooks::getBetaPreferences';

Then, the BetaFeature auto-enroll option will be handled as any other features, and the number of users will be counted normally.

But since its not needed to show the auto-enroll option like the other beta features in the list. We ignore the auto-enroll in the for loop that show the list, and we show the auto-enroll option, as before, just changing the HTMLFormField to another one that was created.

(In reply to comment #6)

I and a team that I am working with, are learning how to contribute with the
MediaWiki, and this maybe will be our first contribution :D.

So we just have submitted the patch Gerrit change #110238

Hi Andre, this is very welcome!
If you need any help, don't hesitate to ask!

Framawiki renamed this task from BetaFeatures: Add number of "Automatically enable all new beta features" users on Special:Preferences (as tooltip?) to Add number of "Automatically enable all new beta features" users on Special:Preferences (as tooltip?).Dec 2 2017, 1:40 PM
Framawiki moved this task from Backlog to Doing on the good first task board.
Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 11:13 AM

Change 110238 had a related patch set uploaded (by Aklapper; author: Mno2):

[mediawiki/extensions/BetaFeatures@master] Show number of users who enabled auto-enroll option

https://gerrit.wikimedia.org/r/110238