Page MenuHomePhabricator
Create Task
Maniphest T61959

Changeslist-legend is not displayed normal on Special:RecentChangesLinked for non-existing page
Closed, ResolvedPublic
Actions

Description

The legend for changes is not displayed normal (totally unstyled by js) if a non-existing page is specified.

Diffing the html-output shows that mediawiki.special.changeslist and mediawiki.special.changeslist.enhanced are not requested from resource loader.

Manually executing "mw.load('mediawiki.special.changeslist');" restores the expected design.

Not a big deal. As far as I see it won't normally occur to users unless they manually type in by mistake a page title which doesn't exist.

example: https://en.wikipedia.org/w/index.php?target=WP%3Aafiow&title=Special%3ARecentChangesLinked
expected: https://en.wikipedia.org/w/index.php?target=WP%3AABF&title=Special%3ARecentChangesLinked

Version: 1.23.0
Severity: trivial
URL: https://en.wikipedia.org/w/index.php?target=WP%3Aafiow&title=Special%3ARecentChangesLinked

Details

Reference
bz59959

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:39 AM
• bzimport added projects: MW-1.23.0-release, MediaWiki-Recent-changes.
• bzimport set Reference to bz59959.
Se4598 created this task.Jan 11 2014, 10:20 PM
duplicatebug added a comment.Jan 12 2014, 10:12 AM

Maybe fixed with gerrit 97451

matmarex added a comment.Jan 12 2014, 12:34 PM

This is definitely fixed by one of the commits on my refactoring stack, I never bothered to find out which one :P – I noticed this was happening sometimes and that it stopped happening after my refactoring.

gerritbot added a comment.Jan 12 2014, 12:36 PM

Change 97451 had a related patch set uploaded by Bartosz Dziewoński:
Always load 'mediawiki.special.changeslist' on SpecialRecentChanges and subclasses

https://gerrit.wikimedia.org/r/97451

gerritbot added a comment.Jan 15 2014, 12:12 AM

Change 97451 merged by jenkins-bot:
Always load 'mediawiki.special.changeslist' on appropriate pages

https://gerrit.wikimedia.org/r/97451

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL