Page MenuHomePhabricator
Create Task
Maniphest T61982

Huggle adding wrong level warnings when warning users
Closed, ResolvedPublic
Actions

Assigned To
Petrb
Authored By
Josve05a
Jan 12 2014, 8:13 PM
Tags
Referenced Files
F12782: tst_testmain.exe
Nov 22 2014, 2:41 AM
F12781: tst_testmain.exe
Nov 22 2014, 2:41 AM
F12780: tst_testmain.exe
Nov 22 2014, 2:41 AM
F12779: tst_testmain.exe
Nov 22 2014, 2:41 AM
F12777: tst_testmain.exe
Nov 22 2014, 2:41 AM
F12778: Qt5Test.dll
Nov 22 2014, 2:41 AM
Subscribers
Josve05a
Luke081515
Petrb
Se4598

Description

Huggle 3.0 Build 796 adds a lvl 2 warning even if one exists already.

See [https://en.wikipedia.org/w/index.php?title=User_talk%3A71.108.77.231&diff=590405095&oldid=590404758 this edit].

Version: 3.0.0
Severity: normal

Details

Reference
bz59982

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:41 AM
• bzimport added a project: Huggle.
• bzimport set Reference to bz59982.
Josve05a created this task.Jan 12 2014, 8:13 PM
Petrb added a comment.Jan 13 2014, 3:49 PM

There may be several reasons for this, either:

  • huggle didn't recognize the lvl 2 warning, because there was no known pattern in the message
  • huggle ignored the lvl 2 warning, because it was old
  • MOST POSSIBLE huggle didn't know about the warning because it was sent between last check of talk page and revert, this can be actually fixed by extra TP re-parse before each user warning OR by fetching the edit token in same moment as first re-parse and reusing it later, in case it fail, it means page was edited and new token needs to be obtained as well as check for templates needs to be done again.
Petrb added a comment.Jan 24 2014, 2:32 PM

https://github.com/huggle/huggle3-qt-lx/commit/7c68154afed9d33efffe753025866d2b3eaa1328

Petrb added a comment.Mar 14 2014, 5:48 PM
  • Bug 61933 has been marked as a duplicate of this bug. ***
Petrb added a comment.Mar 14 2014, 5:48 PM
  • Bug 62646 has been marked as a duplicate of this bug. ***
Petrb added a comment.Mar 14 2014, 5:49 PM

These warnings are giving basetimestamp so mediawiki should reject them unless huggle did parse the recent talk page version, it seems to be a bug in mediawiki?

Se4598 added a comment.Mar 14 2014, 6:16 PM

copied from bug 61933:

se4598 2014-03-03 20:40:51 CET

Which language does your system have? and whats "February" in that language?

If it's not english, then likely that's the cause.
(The section was skipped because the date of the signature was considered invalid b/c parsed with a non english locale;
https://github.com/huggle/huggle3-qt-lx/blob/master/huggle/huggleparser.cpp#L307 following )

gladjonatan 2014-03-03 20:46:40 CET

My system runs with Swedish, and February in Swedish is februari or Februari. (It does not count as a name in Swedish, therefor not written with a capital letter. Except when in beginnings of sentences and stuff like that.)

  • end of copy

additional info: QDate::fromString() is used with MMMM, which considers all long month names, which are "... localized according to the system's default locale settings."

Josve05a added a comment.Mar 14 2014, 7:33 PM

Now Huggle is breaking down totaly.

In this edit (https://en.wikipedia.org/w/index.php?title=User_talk%3ADustyF&diff=599622995&oldid=599622795 ) it added a lvl 1, when a lvl was issued 2 min earlier.

In this edit (https://en.wikipedia.org/w/index.php?title=User_talk%3AWikihelper123454&diff=599621716&oldid=599618528 ) it is adding a lvl 2, when a lvl was already issued ca. 20 min earlier.

On the same user talk page as above, this edit (https://en.wikipedia.org/w/index.php?title=User_talk:Wikihelper123454&diff=next&oldid=599621716 ) added another lvl2, making it 3 lvl 2 on the same talk page.

Se4598 added a comment.Mar 14 2014, 7:45 PM

the third one is different from the others because here a lvl 2 warning was made despite you/huggle itself posted the previous lvl 2 warning. That's maybe a different cause.

Josve05a added a comment.Mar 14 2014, 8:00 PM

I will give a list of url, what lvl HG3 posted, what lvl was already there, and how llong between:

*https://en.wikipedia.org/w/index.php?title=User_talk%3A71.11.159.0&diff=599622987&oldid=599622573
lvl 1
lvl 2
4 min

*https://en.wikipedia.org/w/index.php?title=User_talk%3ARyanhalo98&diff=599622024&oldid=599520539
lvl 1
lvl 1
18 h

*https://en.wikipedia.org/w/index.php?title=User_talk%3A204.129.176.11&diff=599621845&oldid=599619789
lvl 1
lvl 1
14 min

The list goes on, almost 9/10 of all my edits is this way since I updated to the recent build relesed.

Petrb added a comment.Mar 15 2014, 10:56 AM

I don't think there was any significant change since last release, so this would happen even if you used the previous version.

Petrb added a comment.Mar 15 2014, 10:59 AM

Problem here is that huggle doesn't see the talk page, before it post a message, it is mediawiki which merges the warning between the warnings of others. Only proper solution here would be to have mediawiki reject the message in case there was an edit to talk page so that huggle re-parse it, but I don't know if mediawiki can do that.

Other workaround which isn't reliable, would be just to re-parse the talk page everytime before the warning is sent. This has 2 issues:

It significantly worsen the performance and it isn't reliable because some user could in theory send a warning between the check and edit, there is also replication lag (reading page may return older version, while when you write to a page, you access the master sql server which contains the current version) I think this needs to be solved on mediawiki level

Petrb added a comment.Mar 17 2014, 8:14 AM

I am lowering priority because this should now happen less since I implemented expiration time, but until bug https://bugzilla.wikimedia.org/show_bug.cgi?id=62698 is fixed it may still happen

Josve05a added a comment.Mar 18 2014, 2:14 PM

i know that it is fixed and will be in the next pre-built build. But I thought I might as well post this from the 1024 (or what ever buid it is, that is live right now).

https://en.wikipedia.org/w/index.php?title=User_talk%3A190.213.2.61&diff=600157662&oldid=600156817
In these 2 edits, Huggle 3 added 2 lvl 3 warnings after a level 4 already had been given.

As long as the next build is not relesed (for those who don't have the techincal skils to build it them selfs) these kinds of errors will happen.

Petrb added a comment.Mar 20 2014, 2:10 PM

It was already released, try latest version.

But it still may happen because the limit time is 40 seconds, that means if cached talk page is older than 40 seconds, it is auto-parsed again, however if someone send a warning within 40 seconds, it will be scored wrong again. This is something that must be fixed on mediawiki side, so that huggle can safely recognize edit conflicts. As long as mediawiki is not able to tell the client that edit conflict happened, and instead try to resolve it itself, which it now does, this will not be reliable.

Excirial added a comment.Mar 25 2014, 7:18 PM

As far as i can tell from glancing over my edits, it still seems that warnings levels are often incorrect. For example:

I am currently using build 1076 which is currently the latest released build. As far as i can tell Huggle only ups the warning level if i warned a user before. If another editor warned the editor (Irregardless of when, be in in 40 seconds or after 40 seconds) this isn't detected or adjusted for when placing the warning. Looking at the page history it will not display the "1", "2" and so icons for warning level either unless i warned a user before.

Petrb added a comment.Mar 31 2014, 10:28 PM

These icons are different bug, I don't like idea of parsing the talk page on every new edit just to have fancy icons, because that would slow huggle down a lot, instead I think we should fetch the information from IRC feed (if someone send a warning to user they usually have some summary like "Sending warning" etc which would increment the level.

Petrb added a comment.Mar 31 2014, 10:29 PM

I will make a unit test from every talk page which failed this, so keep posting them in this bug (everytime you see huggle issued wrong level, just post it here), so that we ensure new version would do that right

Petrb added a comment.Apr 2 2014, 1:06 PM

this possibly fixed waste majority of these https://github.com/huggle/huggle3-qt-lx/commit/05be236f48517a360f99573253b32c44632574db

Excirial added a comment.Apr 2 2014, 5:14 PM

I've been testing the new 1096 revision for a little bit now and so far the results are promising. After manually checked the warnings levels for the past 25 or so reverts i can say that all of them seem to be spot on so far.

There is one thing i did notice, not sure if it is related:

Huggle did not place a warning though - instead this was displayed in the event log:
"wo 2. apr 16:25:12 2014 ERROR: Unable to deliver the message to 65.18.38.128: Unknown error: articleexists"

I haven't seen this one before so i'm not sure if this is related to the latest changes or if this is something separate altogether.

Josve05a added a comment.Apr 2 2014, 5:49 PM

Using the latest build in this edit HG3 added a lvl 2, when it should have added a lvl 1
https://en.wikipedia.org/w/index.php?title=User_talk%3A209.232.147.121&diff=602447725&oldid=596077638

Petrb added a comment.Apr 3 2014, 10:42 AM

(In reply to gladjonatan from comment #20)

Using the latest build in this edit HG3 added a lvl 2, when it should have
added a lvl 1
https://en.wikipedia.org/w/index.php?title=User_talk%3A209.232.147.
121&diff=602447725&oldid=596077638

https://github.com/huggle/huggle3-qt-lx/commit/4e36234a5eee35b4dd22fd50a0d4e56a091e4f8b fixes it

Petrb added a comment.Apr 3 2014, 11:47 AM

(In reply to Excirial from comment #19)

I've been testing the new 1096 revision for a little bit now and so far the
results are promising. After manually checked the warnings levels for the
past 25 or so reverts i can say that all of them seem to be spot on so far.

There is one thing i did notice, not sure if it is related:

  • On 16:21 today this edit was reverted by another user:

https://en.wikipedia.org/w/index.
php?title=Diary_of_a_Wimpy_Kid&diff=602436176&oldid=602436142

  • On 16:23 the IP editor blanks his talk page:

https://en.wikipedia.org/w/index.php?title=User_talk%3A65.18.38.
128&diff=602436421&oldid=602436180

  • On 16:25 the editor vandalized again and this time i reverted:

https://en.wikipedia.org/w/index.
php?title=Diary_of_a_Wimpy_Kid&diff=602436675&oldid=602436662

Huggle did not place a warning though - instead this was displayed in the
event log:
"wo 2. apr 16:25:12 2014 ERROR: Unable to deliver the message to
65.18.38.128: Unknown error: articleexists"

I haven't seen this one before so i'm not sure if this is related to the
latest changes or if this is something separate altogether.

https://github.com/huggle/huggle3-qt-lx/commit/1225992b272b191afaa5ece3c1d648507c7ef9da

Excirial added a comment.Apr 3 2014, 8:00 PM

One exception i ran into is this IP editor. I reverted two edits made by this user:

However, Huggle immediately warned me the user already had a level 4 warning and asked if i wished to report them. Looking at the user talk page there are plenty of warnings, but none recent:

Excirial added a comment.Apr 3 2014, 10:47 PM

Another example of the above for completeness sake. I tried to revert this edit:

When doing so Huggle reported that the user already had a level 4 warning, and asked if i wished to report it. However, as before there is no recent level 4 warning at the talk page:

Petrb added a comment.Apr 8 2014, 2:11 PM

Did any of these happen using latest huggle? Please post huggle version together with new reports

Petrb added a comment.Apr 8 2014, 2:20 PM

(In reply to Excirial from comment #24)

Another example of the above for completeness sake. I tried to revert this
edit:

https://en.wikipedia.org/w/index.
php?title=Aron_Ralston&diff=602647300&oldid=602367072

When doing so Huggle reported that the user already had a level 4 warning,
and asked if i wished to report it. However, as before there is no recent
level 4 warning at the talk page:

I created unit test https://github.com/huggle/huggle3-qt-lx/commit/e82b6eb6d6ce8f62bb59dca28621e4b8c6537628 for this talk page, but it PASSED just fine, so this issue is likely already fixed in latest huggle

Josve05a added a comment.Apr 8 2014, 5:57 PM

On build 1110:

It added a lvl 1, where a llv 2 should have been added.

Josve05a added a comment.Apr 8 2014, 6:15 PM

On build 1110:

It added a lvl 2, where a lvl 4 should have been added.

Josve05a added a comment.Apr 8 2014, 7:14 PM

On build 1110:

I don't know how long in between the dates it has to be to "reset" the warning level, but...

It added a lvl 1, where a lvl 1 was added only 5 days ago.

Petrb added a comment.Apr 9 2014, 7:11 AM

(In reply to gladjonatan from comment #29)

On build 1110:

I don't know how long in between the dates it has to be to "reset" the
warning level, but...

https://en.wikipedia.org/w/index.php?title=User_talk:216.48.138.
103&oldid=603342430

It added a lvl 1, where a lvl 1 was added only 5 days ago.

yes it's 5 days on english wikipedia, by default it's 30 though on other wikis

Petrb added a comment.Apr 9 2014, 7:17 AM

(In reply to gladjonatan from comment #28)

On build 1110:

https://en.wikipedia.org/w/index.php?title=User_talk:
Nathangrice&oldid=603335334

It added a lvl 2, where a lvl 4 should have been added.

biog3 was not in definitions in config it's now fixed

Josve05a added a comment.May 1 2014, 5:52 PM

It seems to be fixed now. (petan > to ping in the IRC-channel)

Josve05a added a comment.May 4 2014, 8:16 PM

Here it added a lvl 1 when it should have added a lvl 2:

https://en.wikipedia.org/w/index.php?title=User_talk%3A2.125.251.86&diff=607067979&oldid=607067898

Petrb added a comment.May 7 2014, 8:46 PM

I added a unit test for this as well as for other reported pages, this seems to be fixed now

Josve05a added a comment.May 7 2014, 9:44 PM
Josve05a added a comment.May 7 2014, 9:45 PM

oops on Comment 35 is regarding Build 1282.

Josve05a added a comment.May 7 2014, 10:20 PM

Build 1282 (rc1):

Josve05a added a comment.May 10 2014, 11:34 PM

Another one, same build:

Excirial added a comment.May 12 2014, 7:05 PM

I see the same warning level issue in RC1:

Petrb added a comment.May 13 2014, 11:34 AM

I will create a unit test for these but I am pretty sure this was already fixed long time ago, it's just that you are not running latest version

Excirial added a comment.May 13 2014, 12:12 PM

(In reply to Peter Bena from comment #40)

I will create a unit test for these but I am pretty sure this was already
fixed long time ago, it's just that you are not running latest version

Yes, this was fixed a while ago - I am dead certain that this worked just fine in versions prior to RC1. However, ever since I installed RC1 (Build 1282) this issue seems to have resurfaced.

Petrb added a comment.May 13 2014, 1:23 PM

I made a test for every single of these talk pages and all passed, so please update your huggle, it works.

Petrb added a comment.May 13 2014, 1:23 PM

I am on rc2

Josve05a added a comment.May 13 2014, 2:13 PM

Still a bug in rc2. See:
https://en.wikipedia.org/w/index.php?title=User_talk:173.73.16.15&diff=608383593&oldid=608381602

and

https://en.wikipedia.org/w/index.php?title=User_talk:208.68.153.177&diff=608383615&oldid=608380300

Petrb added a comment.May 13 2014, 2:55 PM

I can't reproduce it, both unit tests are just fine.

Can you find some errors in logs? Something like "unable to retrieve talk page of bla bla" or something like that.

Josve05a added a comment.May 13 2014, 3:07 PM

Created attachment 15367
System logs for Comment 47

attachment file_59982.txt ignored as obsolete

Josve05a added a comment.May 13 2014, 3:08 PM

In rc2 on Windows 7.

https://en.wikipedia.org/w/index.php?title=User_talk%3A207.250.60.193&diff=608392913&oldid=608392366

Added lvl 1, should have added a lvl 3

Josve05a added a comment.May 13 2014, 3:47 PM

In rc2 using Windows 7.

Josve05a added a comment.May 13 2014, 3:47 PM

Created attachment 15370
System logs for Comment 48

attachment file_59982.txt ignored as obsolete

Josve05a added a comment.May 14 2014, 8:36 PM

I downgraded to bild 1242, with opes that it would wrok, but instead I found the same problem there.

https://en.wikipedia.org/w/index.php?title=User_talk:164.58.75.210&diff=608574839&oldid=608570883 (A lvl 1, where the users should have been reported)

Josve05a added a comment.May 14 2014, 8:37 PM

typos in Cmment 50 : hopes*, work*

Josve05a added a comment.May 14 2014, 8:37 PM

typos in Comment 50 : hopes*, work*

Josve05a added a comment.May 15 2014, 2:08 PM

Using rc3, on WIndows 7

https://en.wikipedia.org/w/index.php?title=User_talk%3A168.31.88.109&diff=608690122&oldid=608689881 (A lvl 1, should have been a 1vl 2)

Petrb added a comment.May 16 2014, 11:48 AM

I didn't get a single wrong edit on rc3 so far on windows, IMHO the problem is resolved, I will check your configs though

Petrb added a comment.May 16 2014, 11:51 AM

I have wiped your configuration file on english wikipedia, please try now. In case you will have any wrong edit, paste also the logs from huggle. You can also start huggle in debug mode (level 2 or more -vv) the debug logs will be helpful here

Josve05a added a comment.May 16 2014, 11:59 AM

I have tried again, and the problem is still there.

https://en.wikipedia.org/w/index.php?title=User_talk%3A62.171.192.105&diff=608823440&oldid=608823099

(added a lvl 1, should have been a lvl 3)

I will add system logs from debug mode in Comment 57.

Josve05a added a comment.May 16 2014, 12:00 PM

Created attachment 15403
System logs for Comment 56

attachment file_59982.txt ignored as obsolete

Petrb added a comment.May 16 2014, 12:09 PM

Can you pick any other queue in menu?

Josve05a added a comment.May 16 2014, 12:12 PM

I can't use IRC as provider, but I can change from default-queue to filtred edits, if that will help...

Petrb added a comment.May 16 2014, 12:34 PM

Created attachment 15404
Unit

Attached:

tst_testmain.exe1 MBDownload

Petrb added a comment.May 16 2014, 12:36 PM

Created attachment 15405
test

Attached:

Qt5Test.dll178 KBDownload

Petrb added a comment.May 16 2014, 12:37 PM

download test and unit files and place them to folder where huggle is installed, then open command line and navigate to this folder, execute tst_testmain and send me the output

Excirial added a comment.May 16 2014, 12:43 PM

Here you go (Disclaimer: This test was not executed from my regular system)

  • Start testing of HuggleTest *****

Config: Using QtTest library 5.1.1, Qt 5.1.1
PASS : HuggleTest::initTestCase()
FAIL! : HuggleTest::testCaseTalkPageParser0001() 'user->WarningLevel == level' returned FALSE. (level parsed was 0 should be 3!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0002() 'user->WarningLevel == level' returned FALSE. (level parsed was 0 should be 3!!)
..\test\tst_testmain.cpp(85) : failure location
PASS : HuggleTest::testCaseTalkPageParser0003()
PASS : HuggleTest::testCaseTalkPageParser0004()
FAIL! : HuggleTest::testCaseTalkPageParser0005() 'user->WarningLevel == level' returned FALSE. (level parsed was 0 should be 4!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0006() 'user->WarningLevel == level' returned FALSE. (level parsed was 0 should be 1!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0007() 'user->WarningLevel == level' returned FALSE. (level parsed was 0 should be 1!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0008() 'user->WarningLevel == level' returned FALSE. (level parsed was 0 should be 1!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0009() 'user->WarningLevel == level' returned FALSE. (level parsed was 0 should be 1!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0010() 'user->WarningLevel == level' returned FALSE. (level parsed was 0 should be 3!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0011() 'user->WarningLevel == level' returned FALSE. (level parsed was 0 should be 1!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0012() 'user->WarningLevel == level' returned FALSE. (level parsed was 0 should be 1!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0013() 'user->WarningLevel == level' returned FALSE. (level parsed was 0 should be 2!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0014() 'user->WarningLevel == level' returned FALSE. (level parsed was 0 should be 4!!)
..\test\tst_testmain.cpp(85) : failure location
PASS : HuggleTest::testCaseWikiUserCheckIP()
PASS : HuggleTest::testCaseTerminalParser()
PASS : HuggleTest::testCaseConfigurationParse_QL()
PASS : HuggleTest::testCaseScores()
PASS : HuggleTest::cleanupTestCase()
Totals: 8 passed, 12 failed, 0 skipped

  • Finished testing of HuggleTest *****
Josve05a added a comment.May 16 2014, 12:48 PM
  • Start testing of HuggleTest *****

Config: Using QtTest library 5.1.1, Qt 5.1.1
PASS : HuggleTest::initTestCase()
FAIL! : HuggleTest::testCaseTalkPageParser0001() 'user->WarningLevel == level'
returned FALSE. (level parsed was 0 should be 3!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0002() 'user->WarningLevel == level'
returned FALSE. (level parsed was 0 should be 3!!)
..\test\tst_testmain.cpp(85) : failure location
PASS : HuggleTest::testCaseTalkPageParser0003()
PASS : HuggleTest::testCaseTalkPageParser0004()
FAIL! : HuggleTest::testCaseTalkPageParser0005() 'user->WarningLevel == level'
returned FALSE. (level parsed was 0 should be 4!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0006() 'user->WarningLevel == level'
returned FALSE. (level parsed was 0 should be 1!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0007() 'user->WarningLevel == level'
returned FALSE. (level parsed was 0 should be 1!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0008() 'user->WarningLevel == level'
returned FALSE. (level parsed was 0 should be 1!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0009() 'user->WarningLevel == level'
returned FALSE. (level parsed was 0 should be 1!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0010() 'user->WarningLevel == level'
returned FALSE. (level parsed was 0 should be 3!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0011() 'user->WarningLevel == level'
returned FALSE. (level parsed was 0 should be 1!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0012() 'user->WarningLevel == level'
returned FALSE. (level parsed was 0 should be 1!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0013() 'user->WarningLevel == level'
returned FALSE. (level parsed was 0 should be 2!!)
..\test\tst_testmain.cpp(85) : failure location
FAIL! : HuggleTest::testCaseTalkPageParser0014() 'user->WarningLevel == level'
returned FALSE. (level parsed was 0 should be 4!!)
..\test\tst_testmain.cpp(85) : failure location
PASS : HuggleTest::testCaseWikiUserCheckIP()
PASS : HuggleTest::testCaseTerminalParser()
PASS : HuggleTest::testCaseConfigurationParse_QL()
PASS : HuggleTest::testCaseScores()
PASS : HuggleTest::cleanupTestCase()
Totals: 8 passed, 12 failed, 0 skipped

  • Finished testing of HuggleTest *****
Excirial added a comment.May 16 2014, 1:39 PM

Just a thought - would it be an idea to use a regular expression instead of the current string based matching in order to detect the warnings on a user page? Something like this:

#include <QRegularExpression>

QRegularExpression re("<!-- Template:uw-(?<Template>.+?) -->.+\\d{2}:\\d{2}, (?<Date>\\d{1,2} \\w+ 20\\d{2}) \\x28UTC\\x29");

QRegularExpressionMatch match = re.match(page);

if (match.hasMatch()) {
    QString Template = match.captured(1);
    QString Date = match.captured(2);
}

I just tested the concept inside Huggle itself and it seems to work. The result for "Template" contains "Vandalism2" and the result for the Date contains "22 June 2009".

My guess is it could do something like this:

  • Loop trough all the matches for a user page.
  • Check if the date is in range. If not, ignore.
  • If the case is in range: Log the associated warning level if it is higher than the previous highest warning level.

The regex is a first draft so i don't expect it to work in all circumstances just yet, but that could be improved.

Petrb added a comment.May 16 2014, 1:57 PM

I don't like for these reasons:

  • regexes are horribly slow, this would be massive execution in loop over long text in short time
  • this solution isn't very flexible, it can he hardly customized enough to run on any possible wiki installation
  • it could fail just the same as it does now

but yes, we could use some other lightweight regexes just to make it easier for parser

Petrb added a comment.May 16 2014, 2:04 PM

Created attachment 15409
ut 2

Attached:

tst_testmain.exe1 MBDownload

Petrb added a comment.May 16 2014, 2:05 PM

try this

Josve05a added a comment.May 16 2014, 2:09 PM

Created attachment 15410
Result of ut 2 (test 2)

attachment file_59982.txt ignored as obsolete

Petrb added a comment.May 16 2014, 2:16 PM

Created attachment 15411
ut 3

new one

Attached:

tst_testmain.exe1 MBDownload

Josve05a added a comment.May 16 2014, 2:18 PM

Created attachment 15412
Result of ut 3 (test 3)

attachment file_59982.txt ignored as obsolete

Excirial added a comment.May 16 2014, 2:34 PM

Fyi - i just ran test 2 and 3. The results i receive seems to be identical to the results posted above. Once exception: The logging in test 3 reports a localized date and time for me as well.

Petrb added a comment.May 16 2014, 2:36 PM

Created attachment 15414
ut 4

Attached:

tst_testmain.exe1 MBDownload

Josve05a added a comment.May 16 2014, 2:38 PM

Created attachment 15415
Result of ut 4 (test 4)

attachment file_59982.txt ignored as obsolete

Petrb added a comment.May 16 2014, 3:06 PM

Created attachment 15416
ut 5

Attached:

tst_testmain.exe1 MBDownload

Josve05a added a comment.May 16 2014, 3:29 PM

Created attachment 15417
Result of ut 5 (test 5)

attachment file_59982.txt ignored as obsolete

Josve05a added a comment.May 16 2014, 9:46 PM

Using rc4 on Windows 7

https://en.wikipedia.org/w/index.php?title=User_talk%3A165.234.180.57&diff=608853188&oldid=608438527 (added a lvl 1, should have been a lvl 2)

Petrb added a comment.Jun 9 2014, 3:48 PM

reopen if still happens

Excirial added a comment.Jun 18 2014, 7:15 PM

Using Huggle 3.0.2, Build 1616:

Se4598 added a comment.Jun 18 2014, 8:12 PM

<!-- Template:uw-huggleafd1 --> isn't registered in Huggle config at https://en.wikipedia.org/wiki/Wikipedia:Huggle/Config#Warning

Petrb added a comment.Jun 23 2014, 1:18 PM

{{sofixit}}

Josve05a added a comment.Jul 23 2014, 7:42 PM

https://en.wikipedia.org/w/index.php?title=User_talk:213.5.181.218&diff=618164948&oldid=618164933
Added a lvl 4 where it should have reported the user.

Petrb added a comment.Aug 7 2014, 2:03 PM

should be fixed

Josve05a added a parent task: T110818: Wrong warning level messages sent to vandals (tracking).Aug 30 2015, 12:43 AM
Josve05a merged tasks: T64646: Adding level 1 warning, even if a level 2 warning was added just 7 min ago, T63933: HG3 Build 860 added a lvl 1 warning when one already existed.
Restricted Application added a subscriber: Luke081515. · View Herald TranscriptAug 30 2015, 12:45 AM
Josve05a removed a subtask: T64698: Make it possible to specify what to do on edit conflict on action=edit.Aug 30 2015, 12:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL