Maniphest T62040

Include redirects probably should be the default when searching
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• Manybubbles
	Jan 14 2014, 2:56 PM

Description

Include redirects probably should be the default when searching. This doesn't matter for lsearchd/mwsearch too much because they ignore the checkbox. Cirrus doesn't. If it isn't checked cirrus won't search redirects or make suggestions based on redirects.

Version: 1.23.0
Severity: normal

Details

Reference: bz60040

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:53 AM

• bzimport added a project: MediaWiki-Search.

• bzimport set Reference to bz60040.

• bzimport added a subscriber: Unknown Object (MLST).

• Manybubbles created this task.Jan 14 2014, 2:56 PM

Doesn't it already?

// Redirects defaults to true, but we don't know whether it was ticked of or just missing
$default = $request->getBool( 'profile' ) ? 0 : 1;
$this->searchRedirects = $request->getBool( 'redirs', $default ) ? 1 : 0;

It is the default now. They're always included. I removed the checkbox entirely.

Include redirects probably should be the default when searchingClosed, ResolvedPublicActions

Description

Details

Event Timeline

Include redirects probably should be the default when searching
Closed, ResolvedPublic
Actions