Maniphest T62099

multimediaviewer-repository contains the name of the local wiki instead of the remote repository when using InstantCommons
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Dereckson
	Jan 15 2014, 7:09 PM

Description

On a wiki not using a full remote repository configuration but using the InstantCommons quick settings, the multimediaviewer-repository message contains the local wiki name.

[ Bug analysis ]

This remote repository name is defined in the LIP.setRepoDisplayName method:
displayname = displayname || mw.config.get( 'wgSiteName' );

This method is called in resources/ext.multimediaViewer/ext.multimediaViewer.js:
ui.setRepoDisplayName( repoData.displayname, repoData.isLocal );

The bug has been introduced in change Ife8293c86683ea914b1a5a60000584b501d92e55 and the new data model, where repoData.displayname doesn't seem to be set when using $wgInstantCommons instead of a full foreign repository configuration.

Version: unspecified
Severity: normal

Details

Reference: bz60099

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:57 AM

• bzimport added a project: MediaViewer.

• bzimport set Reference to bz60099.

• bzimport added a subscriber: Unknown Object (MLST).

Dereckson created this task.Jan 15 2014, 7:09 PM

This doesn't have anything to do with 'full' vs. 'quick' settings ($wgUseInstantCommons is just a shortcut for a given set of full settings, anyway) - I think it's caused by displayName being misspellt as displayname at a few places. IIRC that has just been fixed (maybe not merged yet?).

[ Adding code-update-regression keyword. ]

Could you please check if this is still happening with the latest master?

Gergo, do you think this might have been fixed by https://gerrit.wikimedia.org/r/#/c/115314/ ? Or is it totally unrelated?

Unrelated, that commit only affected favicons.

I think this was caused by a bug that was fixed a long time ago, and I cannot reproduce it locally. I'm closing the bug; Dereckson, please reopen if you still experience it.

• Gilles added a project: Multimedia.Dec 4 2014, 10:20 AM

• Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:24 AM

• Gilles moved this task from Untriaged to Done on the Multimedia board.

• Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:23 AM

multimediaviewer-repository contains the name of the local wiki instead of the remote repository when using InstantCommonsClosed, ResolvedPublicActions

Description

Details

Event Timeline

multimediaviewer-repository contains the name of the local wiki instead of the remote repository when using InstantCommons
Closed, ResolvedPublic
Actions