Page MenuHomePhabricator

Flow: viewing a moderated topic you don't have userrights to see, shows error page
Closed, DeclinedPublic

Description

If a topic is hidden/deleted/suppressed, and you don't have the rights to unhide or restore it (e.g. you're not logged in), then you don't see the topic box at all. This is great on a Flow board, spam is invisible for people who can't reveal it.

But if you follow a link to a flagged topic and don't have the rights, you see an empty page containing just

<Flow board name in h1>

It looks broken.

If you have the rights, then you see

<topic title in h1>
"This topic was started on <Flow board name>" gray link line
[This topic was deleted by Admin] topic box

I think users without rights to unhide/restore should see something like

"Flagged content" as h1
"This flagged topic was started on <Flow board name>" gray link line

the details will change if we add a crumbtrail from topic back to post.


Version: master
Severity: normal
URL: http://ee-flow.wmflabs.org/wiki/User_talk:Spage?workflow=050d5136fb93f00fc8b1fa163e68c4ac

Details

Reference
bz60155

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:01 AM
bzimport set Reference to bz60155.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

The WMF core features team tracks this bug on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/flow/cards/725, but people from the community are welcome to contribute here and in Gerrit.

Viewing a deleted topic, as a non-admin, gets an error page:
eg. https://www.mediawiki.org/wiki/Topic:Ryqpaslvstkeunf1
gives:

PHP fatal error in /usr/local/apache/common-local/php-1.24wmf16/extensions/Flow/includes/Templating.php line 231:
Argument 1 passed to Flow\Templating::getContent() must be an instance of Flow\Model\AbstractRevision, null given, called in /usr/local/apache/common-local/php-1.24wmf16/extensions/Flow/includes/Block/Topic.php on line 490 and defined

but an admin sees the normal collapsed white topic box.

(possibly related to bug 67595 ?)

Reported at https://www.mediawiki.org/wiki/Topic:Rz7mob6cmup1bosc

This no longer causes a fatal error.
If I follow the link Quiddity posted in #c2 I can see the heading error and it tells me I don't have permission.

I don't think there is anything left to do here!