CodeEditor doesn't automatically type matching closing } when I type {
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• bzimport
	Jan 17 2014, 2:05 AM

Description

Author: gryllida

Description:
Typing "{" is expected to produce this output:

{<cursor here>}

Now, it produces this instead, at test.wikipedia.org:

{<cursor here>

It also works at en.wikipedia.org right now, and it worked at test.wikipedia.org yesterday.

Version: unspecified
Severity: normal

Details

Reference: bz60156

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:01 AM

• bzimport added a project: CodeEditor.

• bzimport set Reference to bz60156.

• bzimport added a subscriber: Unknown Object (MLST).

• bzimport created this task.Jan 17 2014, 2:05 AM

Are you sure it's supposed to add a matching brace?

gryllida wrote:

Re-read last line of comment 1.
It was convenient.

gryllida wrote:

(In reply to comment #2)

Re-read last line of comment 1.
It was convenient.

Sorry, of the description, not of comment 1.

It seems likely that it broke in 1.23wmf11, which just deployed to testwp yesterday (and isn't on enwp yet). I can definitely confirm it now.

I'll inquire with the ACE developers if there is any known issue in their last release. It seems to work just fine in their trunk version http://ace.c9.io/build/kitchen-sink.html if you "enable behaviours".

but if i do that in the MW version (which is the december ACE release), i don't see any result.

Since I'm getting on a plane within 24h: https://github.com/ajaxorg/ace/issues/1770

Confirmed that it was broken in the release that I updated CodeEditor to. I'll submit a new update into gerrit soon

Change 108050 had a related patch set uploaded by TheDJ:
Update ACE to Jan 17, 2014

https://gerrit.wikimedia.org/r/108050

Change 108050 merged by jenkins-bot:
Update ACE to Jan 17, 2014

https://gerrit.wikimedia.org/r/108050

The patch does not appear to have fixed the problem on the beta cluster.

Change 118979 had a related patch set uploaded by TheDJ:
Update ACE to Mar 16, 2014

https://gerrit.wikimedia.org/r/118979

Change 118979 merged by jenkins-bot:
Update ACE to Mar 16, 2014