Page MenuHomePhabricator

asset-check.py and other front end performance instrumentation needs further thought
Closed, ResolvedPublic

Description

Re: https://github.com/wikimedia/operations-puppet/blob/production/modules/webperf/files/asset-check.py

This asset-check.py script currently checks a few selected main pages and aggregates the data into Ganglia graphs, as I understand it. A better approach is probably needed here given that this aggregation makes diagnosis of issues more difficult when examining the graphs and attempting to trace what caused a particular spike.

This script also seems to import itertools needlessly and could use minor additional comments (why the reload(sys)?).

Generally, front end performance instrumentation needs some love. This will probably be the subject of future tickets.

Details

Reference
bz60193

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:04 AM
bzimport set Reference to bz60193.
bzimport added a subscriber: Unknown Object (MLST).

Change 108823 had a related patch set uploaded by Ori.livneh:
asset-check: report to Graphite rather than Ganglia

https://gerrit.wikimedia.org/r/108823

Change 108823 merged by Ori.livneh:
asset-check: report to Graphite rather than Ganglia

https://gerrit.wikimedia.org/r/108823

Change 108831 had a related patch set uploaded by Tim Landscheidt:
webperf: Remove misleading references to Ganglia

https://gerrit.wikimedia.org/r/108831

Change 108831 merged by Ori.livneh:
webperf: Remove misleading references to Ganglia

https://gerrit.wikimedia.org/r/108831

Dzahn claimed this task.
Dzahn subscribed.

It seems Ori fixed this by moving to Graphite rather than Ganglia.

Being bold and closing this ticket from 2014, also given that we will get rid of Ganglia soon.