Auto-add Gerrit reviewers to changesets when linked with associated Phabricator tasks on a per-user opt-in basis
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• MZMcBride
	Jan 18 2014, 6:52 PM

Description

For any bug in Bugzilla, there is a group of e-mail addresses involved: reporter, assignee, people on the CC list, people who have commented, et al.

From this list of users, individuals should be able to opt-in to the ability to automatically be made reviewers of any associated Gerrit patches (as identified by the "Bug:" keyword or similar).

This is likely a task for Gerrit Notification Bot, but there may be a much better idea for doing this.

A user opting in to this feature would automatically have all of his or her discovered relationships identified and cross-referenced. Opting in to this feature might consist of a list somewhere or a user preference somewhere or something, I don't know.

And whatever is adding reviewers to Gerrit changesets should also be able to support e-mail address aliases. Some e-mail addresses in Bugzilla won't match those in Gerrit.

Version: wmf-deployment
Severity: enhancement

Details

Reference: bz60209

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 3:05 AM

• bzimport added a project: Gerrit.

• bzimport set Reference to bz60209.

• bzimport added a subscriber: Unknown Object (MLST).

• MZMcBride created this task.Jan 18 2014, 6:52 PM

There is a ReviewerBot which is adding some reviewers to change sets, maybe that bot can get the emails from the bug and add it as reviewer or the bot is using the bugzilla name of the account or both, if the user opt-in.

We do not have such data now anymore, as Phabricator does not expose email addresses.

Aklapper renamed this task from Auto-add Gerrit reviewers to changesets when linked with associated Bugzilla bug reports on a per-user opt-in basis to Auto-add Gerrit reviewers to changesets when linked with associated Phabricator tasks on a per-user opt-in basis.Feb 10 2015, 1:13 AM

Aklapper set Security to None.

In T62209#1026784, @Aklapper wrote:

We do not have such data now anymore, as Phabricator does not expose email addresses.

On the other hand, we now have LDAP, which means it is possible to link one's Phabricator and Labs (Gerrit) accounts.

Can Herald do this? I notice that @Aklapper now gets auto-subscribed to some set of tasks.

When creating a new Herald rule, the available commit related options are:

Commits
- React to new commits appearing in tracked repositories. Commit rules can send email, flag commits, trigger audits, and run build plans.
Commit Hook: Branches/Tags/Bookmarks
- React to branches and tags being pushed to hosted repositories. Hook rules can block changes and send push summary mail.
Commit Hook: Commit Content
- React to commits being pushed to hosted repositories. Hook rules can block changes and send push summary mail.

Obviously this all refers to commits within Diffusion/Differential, not to external entities like Gerrit via LDAP or such.

Umherirrender unsubscribed.Sep 29 2015, 3:19 PM

Paladox edited projects, added GerritBot; removed Gerrit.Jul 30 2016, 2:26 PM

The intent was to have bug subscribers to also be added to a Gerrit change which implies the Gerrit changes refer to the task. In this case, there is a notification send to the Phabricator task(s) and all subscriber get notified by Phabricator. I guess that is sufficient If recipients do not react to the email, they are unlikely to react on a review request emails origination from Gerrit and that seems overall redundant (two emails would be send).

Auto-add Gerrit reviewers to changesets when linked with associated Phabricator tasks on a per-user opt-in basisClosed, ResolvedPublicActions

Description

Details

Event Timeline

Auto-add Gerrit reviewers to changesets when linked with associated Phabricator tasks on a per-user opt-in basis
Closed, ResolvedPublic
Actions