Page MenuHomePhabricator

Kill tabs in operations/puppet's manifests/admins.pp
Closed, ResolvedPublic

Description

https://git.wikimedia.org/blob/operations%2Fpuppet/2114110b6b55ec4efb38bd8b19baadf6675bf9e0/manifests%2Fadmins.pp

This file has inconsistent indentation. It should either use tabs or spaces, not some crazy mixture of the two.


Version: wmf-deployment
Severity: trivial

Details

Reference
bz60277

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:51 AM
bzimport set Reference to bz60277.

it should use 4 spaces. we changed our style since when this was created.

This should be as simple as running :%s/\t/ /g in vim... getting it through CR w/o conflicts might be more of a problem.

exactly. https://wikitech.wikimedia.org/wiki/Puppet_coding#Spacing.2C_Indentation.2C_.26_Whitespace

" Wikimedia style uses 4 spaces for indentation
autocmd BufRead */wmf/puppet/* set sw=4 ts=4 et

open the file, :retab, :wq, done

-> https://wikitech.wikimedia.org/wiki/Puppet_coding#tab_character_found_on_line_..

Change 118961 had a related patch set uploaded by 01tonythomas:
Kill tabs in operations/puppets manifests/admins.pp

https://gerrit.wikimedia.org/r/118961

Change 118961 abandoned by 01tonythomas:
Kill tabs in operations/puppets manifests/admins.pp

Reason:
Duplicate of https://gerrit.wikimedia.org/r/#/c/118794/

https://gerrit.wikimedia.org/r/118961

Change 118794 had a related patch set uploaded by 01tonythomas:
lint admins.pp-pt01-replace tabs and nothing else

https://gerrit.wikimedia.org/r/118794

puppet-lint admins.pp | grep -i "tab char" | wc -l
0

:)