Page MenuHomePhabricator

Preprocessor should not use cache if previously unknown tag is now registered by an extension
Closed, DeclinedPublic

Description

Author: physik

Description:
If syntaxhighlight is installed on a wiki that already has pages containing <syntaxhighlight> tags, the preprocessor loads the elements from memcached [Preprocessor] Loaded preprocessor XML from memcached (key wiki:preprocess-xml:...

We should either cause the cache to be by passed in that case, or instruct admins to clear cache after installation of Geshi if they have pre-existing pages like that.

Details

Reference
bz60308

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:53 AM
bzimport added a project: SyntaxHighlight.
bzimport set Reference to bz60308.
bzimport added a subscriber: Unknown Object (MLST).
Krinkle renamed this task from Enabling syntaxhighlight on a wiki with <syntaxhighlight> elements makes preprocessor load elements from memcached to Preprocessor should not use cache if previously unknown tag is now registered by an extension.Jan 5 2015, 1:04 PM
Krinkle updated the task description. (Show Details)
Krinkle added a project: MediaWiki-Parser.
Krinkle set Security to None.
Krinkle removed a subscriber: Unknown Object (MLST).
Krinkle claimed this task.

I don't think that kind of cache behaviour is feasible or desirable.

It would require either including the tag registration in the cache-key, or retrieve the information from cache (which would make it slower). And we may not want to instantly invalidate existing cache when an extension is (temporarily?) uninstalled. It will naturally roll over within the cache expiration (typically 30 days).

I'd say it's unlikely for a wiki to have pre-existing pages using the tag as the authors of those pages would have no reason to use the tag (it wouldn't have worked yet). If you're setting up a new wiki and imported pages before enabling the relevant extensions, one could consider purging those individual pages (or clearing the parser cache indeed).