Page MenuHomePhabricator

VisualEditor: Opening and closing the gallery inspector without making any change causes a transaction
Closed, ResolvedPublic8 Estimated Story Points

Description

Steps to reproduce:

1.Open a page which has a gallery inside it with VE
2.Select the gallery and open the gallery inspector
3.Close the gallery inspector

Observed Result:

The "Save page" button of the page gets enabled although no change has been made in the gallery inspector

Test Environment: https://test2.wikipedia.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5
Page:https://test2.wikipedia.org/wiki/Thedomtest


Version: unspecified
Severity: minor

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:53 AM
bzimport set Reference to bz60311.

Change 315449 had a related patch set uploaded (by Tchanders):
WIP Update gallery dialog actions to reflect presence of changes

https://gerrit.wikimedia.org/r/315449

Change 315449 abandoned by Tchanders:
WIP Update gallery dialog actions to reflect presence of changes

Reason:
This was split into two patches

https://gerrit.wikimedia.org/r/315449

Change 342240 had a related patch set uploaded (by Tchanders):
[mediawiki/extensions/VisualEditor] Update gallery actions in response to changes

https://gerrit.wikimedia.org/r/342240

Change 342240 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor] Update gallery actions in response to changes

https://gerrit.wikimedia.org/r/342240

Jdforrester-WMF assigned this task to Tchanders.
Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF moved this task from Freezer to Blocked on the VisualEditor board.