Page MenuHomePhabricator

www.wikivoyage.org links to https://zh.wikipedia.org/zh-/ which is a 404
Closed, ResolvedPublic

Details

Reference
bz60367

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:57 AM
bzimport set Reference to bz60367.
bzimport added a subscriber: Unknown Object (MLST).

Please set the keyword as i18n.

Hi, where exactly and how to reproduce?

In the line
Ελληνικά • עברית • Română • Svenska • Українська • 中文
under the search field the link goes to
https://zh.wikivoyage.org/

This shouldn't be a bug on bugzilla. The portal exists at https://meta.wikimedia.org/wiki/Www.wikivoyage.org_template and should be fixed via meta

(In reply to comment #4)

This shouldn't be a bug on bugzilla. The portal exists at
https://meta.wikimedia.org/wiki/Www.wikivoyage.org_template and should be
fixed
via meta

Even if the portal template is right, the HTML given by the server is still wrong.

(In reply to comment #3)

Hi, where exactly and how to reproduce?

In the line
Ελληνικά • עברית • Română • Svenska • Українська • 中文
under the search field the link goes to
https://zh.wikivoyage.org/

Maybe because we've set "Content language variant" in our pref? I find the URL being "/zh-/" appended, and two other wikivoygers get "/zh-cn/" & "/zh-tw/".

Just found that there might actually a script causing this, as my browser gets the right URL in the first sec, and appended a wrong path a sec later.

(In reply to comment #6)

Just found that there might actually a script causing this, as my browser
gets
the right URL in the first sec, and appended a wrong path a sec later.

Yeah, this is obviously caused by https://meta.wikimedia.org/wiki/MediaWiki:Gadget-wm-portal.js

If you had reported on Meta I may have seen this faster, sorry.

Code snippet: $("zh_wiki").href += "zh-" + locale + "/";

(In reply to comment #7)

(In reply to comment #6)

Just found that there might actually a script causing this, as my browser
gets
the right URL in the first sec, and appended a wrong path a sec later.

Yeah, this is obviously caused by
https://meta.wikimedia.org/wiki/MediaWiki:Gadget-wm-portal.js

If you had reported on Meta I may have seen this faster, sorry.

Code snippet: $("zh_wiki").href += "zh-" + locale + "/";

Want me to just remove the locales for zhwikivoyage?

(In reply to comment #8)

Want me to just remove the locales for zhwikivoyage?

Looks good to me.

(In reply to comment #9)

(In reply to comment #8)

Want me to just remove the locales for zhwikivoyage?

Looks good to me.

It need some consensus,I think.

(In reply to comment #10)

It need some consensus,I think.

Two ways to fix:

  1. Remove the locales for zhwikivoyage.
  2. Set $wgVariantArticlePath

True, removing the locales needs some consensus, but as $wgVariantArticlePath is not set, removing the locales IMO is a proper fix.

Could you CC someone who knows how to set $wgVariantArticlePath? The easiest fix would just be to remove locales from www.wikivoyage.org, which is just a quick HTML edit on Meta. I'm not sure how you want this to be done. Is there consensus for either change?

(In reply to comment #12)

Is there consensus for either change?

No consensus; we just spot the bug and reported it.

Change 109456 had a related patch set uploaded by Reedy:
Set wgVariantArticlePath for zhwikivoyage

https://gerrit.wikimedia.org/r/109456

Change 109456 merged by jenkins-bot:
Set wgVariantArticlePath for zhwikivoyage

https://gerrit.wikimedia.org/r/109456

I've set wgVariantArticlePath as per other zh wikis

Reopen since I can confirm comment #18 (still 404).

Please set variant aliases on git operations/apache-config.

(In reply to comment #21)

Not what the bug says.

Please revert. https://www.wikivoyage.org _does_ _link_ _to_ https://zh.wikipedia.org/zh-* _and_ _is_ _still_ 404

Ignore me today, I'm apparently blind or cannot read properly ;-)

(In reply to comment #24)

Ignore me today, I'm apparently blind or cannot read properly ;-)

Will /r/109456 fix this?

CC'ing Reedy to hopefully get this merged (three +1s) and deployed soon.

No longer 404 (bug 60473). Marking as FIXED.