Page MenuHomePhabricator

Remove deprecated $wgAutopromoteOnce
Closed, InvalidPublic

Description

Author: ginger

Description:
Per Bug 59113 we looked around the code for things that have been deprecated
and found $wgAutopromoteOnce at includes/DefaultSettings.php:4502

Details

Reference
bz60457

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:04 AM
bzimport set Reference to bz60457.
bzimport added a subscriber: Unknown Object (MLST).

Why do you think this is deprecated?

I'd love to know *why* you think this is deprecated (references for statements are welcome).

[[mw:Manual:$wgAutopromoteOnce]] does not say that this is deprecated (should it use [[mw:Template:Deprecated]]?), and a quick grep shows:

./extensions/FlaggedRevs/FlaggedRevs.setup.php: $wgAutopromoteOnce['onEdit']['editor'] = $criteria;
./core/includes/DefaultSettings.php:$wgAutopromoteOnce = array(
./core/includes/DefaultSettings.php:$wgAutopromoteOnceLogInRC = true;
./core/includes/Autopromote.php: * @param string $event key in $wgAutopromoteOnce (each one has groups/criteria)
./core/includes/Autopromote.php: * @see $wgAutopromoteOnce
./core/includes/Autopromote.php: global $wgAutopromoteOnce;
./core/includes/Autopromote.php: if ( isset( $wgAutopromoteOnce[$event] ) && count( $wgAutopromoteOnce[$event] ) ) {
./core/includes/Autopromote.php: foreach ( $wgAutopromoteOnce[$event] as $group => $cond ) {
./core/includes/Autopromote.php: wfWarn( 'recCheckCondition() given XOR ("^") condition on three or more conditions. Check your $wgAutopromote and $wgAutopromoteOnce settings.' );
./core/includes/User.php: * @param string $event key in $wgAutopromoteOnce (each one has groups/criteria)
./core/includes/User.php: * @see $wgAutopromoteOnce
./core/includes/User.php: global $wgAutopromoteOnceLogInRC, $wgAuth;
./core/includes/User.php: if ( $wgAutopromoteOnceLogInRC ) {

Currently I am tempted to close this report as INVALID. :)

ginger wrote:

Not actually deprecated. I misinterpreted the comments due to submitting a
series of seven bugs at once. Thanks for letting me know!