Page MenuHomePhabricator

videos not working (at least on Firefox and Chrome, on GNU/Linux) in some circumstances
Closed, ResolvedPublic

Description

Many videos on Wikipedia are no longer working for me. I've tested on my Debian Jessie system with Chromium 31.0.1650.63 and Iceweasel 24.2.0, and on my Ubuntu 13.10 system with Firefox 26.

When I click to play, I get an overlay box with no content (see attachment).

Videos that don't work:
https://en.wikipedia.org/wiki/Wikipedia:Training/For_students/Text_editing
https://outreach.wikimedia.org/wiki/Education_Portal/Tips_and_Resources#Videos

Videos that work:
The video here in mainspace: https://en.wikipedia.org/wiki/Beer_bottle#Closure
All videos when a page is in preview mode.

(I guess that some necessary javascript isn't being loaded in the cases of videos that don't work?)


Version: unspecified
Severity: critical

Details

Reference
bz60474

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 3:05 AM
bzimport set Reference to bz60474.

mdale wrote:

Looks like a critical issue. Investigating.

@Bawolff, any of the optimization fixes possibly related here?

Created attachment 14380
screenshot of the blank overlay

Attached:

video_not_working_overlay.png (1×1 px, 185 KB)

(In reply to comment #1)

Looks like a critical issue. Investigating.

@Bawolff, any of the optimization fixes possibly related here?

Yes, we recently changed js to load only on pages that have videos on them.

Re sage: You actually had component right the first time :)

(In reply to comment #4)

(In reply to comment #1)

Looks like a critical issue. Investigating.

@Bawolff, any of the optimization fixes possibly related here?

Yes, we recently changed js to load only on pages that have videos on them.

I think I know what happened. Its only indirectly related to the above fix. Issue should be resolved soon.

(In reply to comment #6)

(In reply to comment #4)

(In reply to comment #1)

Looks like a critical issue. Investigating.

@Bawolff, any of the optimization fixes possibly related here?

Yes, we recently changed js to load only on pages that have videos on them.

I think I know what happened. Its only indirectly related to the above fix.
Issue should be resolved soon.

Sorry for being cryptic. What happened was that during the deployment of I7a6da6c62, wikis on 1.23wmf10 accidentally had the fix for bug 56699 reverted, this caused a mismatch between js and cached pages, breaking stuff. CSteipp just re-applied the patch, fixing the issue