Maniphest T62475

default limit
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• bzimport
	Jan 27 2014, 4:20 PM

Tags

Referenced Files

None

Subscribers

• Manybubbles

Description

Author: physik

Description:
Why does SearchEngine::Create set the default limit to 0 whereas the default value in the class is set to 10.
ll 488: $search->setLimitOffset( 0, 0 );
class SearchEngine {
ll 33: var $limit = 10;
I'd vote to change the default limit for new instances to 10 as well.

Version: 1.23.0
Severity: normal

Details

Reference: bz60475

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:05 AM

• bzimport added projects: MW-1.23.0-release, MediaWiki-Search.

• bzimport set Reference to bz60475.

• bzimport created this task.Jan 27 2014, 4:20 PM

Change 109679 had a related patch set uploaded by Chad:
Don't override limits and offsets in SearchEngine::create()

https://gerrit.wikimedia.org/r/109679

Change 109679 merged by jenkins-bot:
Don't override limits and offsets in SearchEngine::create()

https://gerrit.wikimedia.org/r/109679