Page MenuHomePhabricator

VisualEditor: Diff styling in save dialog is broken
Closed, ResolvedPublic

Description

Screenshot of the bug

The diff in the save dialog isn't being styled correctly, which causes highlighted text to overlap with text above it. Timo tells me that this is due to a missing line-height style.

This is exacerbated by bug 60494. which causes the save dialog to be narrower than it should be, which means lines wrap more often and highlighted text more frequently has text directly above it.


Version: unspecified
Severity: normal

Attached:

diff-overlapping.png (116×240 px, 9 KB)

Details

Reference
bz60497

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:07 AM
bzimport set Reference to bz60497.

So I think we just need to apply line-height: 1.6px to the body of the frame like MW core does for #bodyContent, .mw-body-content (but I don't think we should use those here as they apply some other changes which don't look right e.g. font-size: 0.875em)

  • Bug 57300 has been marked as a duplicate of this bug. ***