| Bawolff | |
| Jan 29 2014, 5:21 AM |
| F12892: patch.txt | |
| Nov 22 2014, 2:53 AM |
If there's a really long error in transcode (for example due to a "cli progress bar", entire thing is output). This is to the point where it has crashed my browser. Would be better if say the first 750 bytes and the last 750 bytes are shown, with the middle being omitted. Probably best not to even put the super-long error message in the db. (Also be cool if we figure out a command line option to disable the progress bar from being output)
Version: unspecified
Severity: normal
Example of bug:
*Click on Error in transcode on 2014-02-15T02:06:28 for the 720p transcode
*Note how its a couple megabytes worth of error message! (may freeze your browser)
umange wrote:
Error message truncated by simply creating another one
Shows the difference between the earlier WebTranscodeJobs.php and the updated one.
Attached:
Id prefer if this used something like $wgContLang->truncate(). C style string munching doesnt work too well for multibyte characters, and seems out of place in php.
Hi Umang! Thanks for your patch!
You are welcome to use Developer access
https://www.mediawiki.org/wiki/Developer_access
to submit this as a Git branch directly into Gerrit:
https://www.mediawiki.org/wiki/Git/Tutorial
Putting your branch in Git makes it easier to review it quickly. If you don't want to set up Git/Gerrit, you can also use https://tools.wmflabs.org/gerrit-patch-uploader/