Page MenuHomePhabricator

TMH totally broken on mobile
Closed, ResolvedPublic

Description

As a first step (If we don't want to load all its js until that's made more efficient) even loading only resources/PopUpThumbVideo.css on mobile would make things considerably less broken


Version: unspecified
Severity: normal

Details

Reference
bz60565

Related Objects

StatusSubtypeAssignedTask
OpenNone
Resolved brion
Resolved brion
Resolved brion
Resolved brion
ResolvedTheDJ
Resolved brion
Resolved brion
ResolvedTheDJ
ResolvedTheDJ
ResolvedTheDJ
ResolvedJdforrester-WMF
Resolved brion
Resolved brion
ResolvedTheDJ
Resolved brion
ResolvedTheDJ
ResolvedTheDJ
InvalidNone
Resolvedovasileva
ResolvedLadsgroup
ResolvedQuiddity
ResolvedFeature brion
ResolvedBUG REPORTTheDJ
ResolvedKrinkle

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:53 AM
bzimport set Reference to bz60565.

ogv.js support patches for bug 61823 include a lightweight player overlay targeted at MobileFrontend.

Gilles triaged this task as Medium priority.Nov 24 2014, 3:44 PM
Gilles added a project: Multimedia.
Gilles subscribed.

New work in progress at https://gerrit.wikimedia.org/r/#/c/217485/ -- more modest, no fancy routed overlay (simple inline view). Still needs some work to add controls when using ogv.js.

Temporary de-assign & re-assign, putting this back on the table on a limited schedule. :)

Re-claiming this, doing another cleanup pass on ogv.js and TMH based on the partial but incomplete improvements in Safari.

Right now the old/legacy media player is not appearing on Mobile View via Chrome mobile 97.0.4692.98 on a Samsung Galaxy phone.

Screenshot_20220122-080553_Chrome.jpg (2×1 px, 904 KB)
Screenshot_20220122-075115_Chrome.jpg (2×1 px, 756 KB)
Screenshot_20220122-080600_Chrome.jpg (2×1 px, 532 KB)
Screenshot_20220122-075033_Chrome.jpg (2×1 px, 472 KB)

Will switch to beta player for now.

Strangely, the old player still works on Safari mobile.

073F37C4-198E-41A5-AD98-5D0D6A283FE0.jpeg (1×640 px, 136 KB)
D43E6233-58C8-4F10-AB37-FD5D4421A862.jpeg (1×640 px, 113 KB)

But I don't see subtitles running on mobile view

Right now the old/legacy media player is not appearing on Mobile View via Chrome mobile 97.0.4692.98 on a Samsung Galaxy phone.

Whoops, that seems like that is my mistake T291591: Video thumbnail extends beyond mobile screen width on File pages. Apparently when you set height to auto on audio elements in Chrome, it makes it height:0

Strangely, the old player still works on Safari mobile.

073F37C4-198E-41A5-AD98-5D0D6A283FE0.jpeg (1×640 px, 136 KB)
D43E6233-58C8-4F10-AB37-FD5D4421A862.jpeg (1×640 px, 113 KB)

But I don't see subtitles running on mobile view

Subtitles only work if you have an area to draw them to. This is one of the reasons why the new player pops up a dialog. (and why the old player on desktop pops up an extra area as well.)

When will the patch be deployed? The old player still hasn't appeared yet on Chrome mobile.

When will the patch be deployed? The old player still hasn't appeared yet on Chrome mobile.

Most wiki's today, most wikipedia's Thursday (assuming that all goes alright).