Page MenuHomePhabricator
Create Task
Maniphest T62604

CoreParserFunctions::formatRaw needs to use page language
Closed, ResolvedPublic
Actions

Description

The parser function {{#expr: }} appears to produce different results on Translations: pages than it does in other namespaces.

This was first brought to our attention on Wikimedia Commons with this edit[1]; after some playing around, I managed to isolate the problem to {{#expr:}} with this edit[2], and confirmed the different behaviour by adding the same code to a page in my own user space[3] and then testing it again using preview at a different page in the Commons: namespace[4].

References

Version: unspecified
Severity: normal

Details

Reference
bz60604
SubjectRepoBranchLines +/-
Parser functions now format numbers according to page language (2nd attempt)mediawiki/coremaster+44 -16
Parser functions now format numbers according to page languagemediawiki/coremaster+36 -16
Parser functions now format numbers according to page languagemediawiki/coreREL1_28+36 -16
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:55 AM
• bzimport added a project: MediaWiki-Parser.
• bzimport set Reference to bz60604.
• bzimport added a subscriber: Unknown Object (MLST).
tomasz created this task.Jan 29 2014, 11:16 PM
Nikerabbit added a comment.Jan 30 2014, 9:52 AM

Please provide more detail. What is the actual value? What is expected value.

"{{#expr:{{formatnum:{{PAGESINCATEGORY:Quality images}}|R}} - 100}}" is too complex example to understand what is going on.

Nemo_bis added a comment.Jan 30 2014, 9:58 AM

I doubt this is a Translate bug: as I already told Odder, he/we need to verify whether #expr wants formatted or unformatted numbers and what assumptions it makes on content language...

tomasz added a comment.Jan 30 2014, 10:00 AM

As demonstrated in [3], the expected value of that function is 61390; the output on that Translations: page is -38.465.

(In reply to comment #2)

I doubt this is a Translate bug: as I already told Odder, he/we need to

The function behaves the same way on regular MediaWiki: pages (tested in NS_USER and NS_PROJECT, see above), but produces different results in Translations: — hence the assumption the bug lies in the latter.

Nikerabbit added a comment.Jan 30 2014, 10:10 AM

There are at least four places where something can go wrong in that example. Please narrow it down.

Nemo_bis added a comment.Jan 30 2014, 10:13 AM

(In reply to comment #3)

The function behaves the same way on regular MediaWiki: pages (tested in
NS_USER and NS_PROJECT, see above), but produces different results in
Translations: — hence the assumption the bug lies in the latter.

I don't see any MediaWiki:/ns8 page in the examples. You can see the page language in action=info.

tomasz added a comment.Jan 30 2014, 10:18 AM

(In reply to comment #5)

I don't see any MediaWiki:/ns8 page in the examples. You can see the page
language in action=info.

Ignore the colon, I meant MediaWiki pages irrespective of their namespaces.

tomasz added a comment.Jan 30 2014, 10:28 AM

(In reply to comment #4)

There are at least four places where something can go wrong in that example.
Please narrow it down.

OK, it appears the problem lies within {{formatnum: }} and not in {{#expr:}}: compare https://commons.wikimedia.org/w/index.php?diff=115117520&oldid=115094092 and https://commons.wikimedia.org/w/index.php?diff=115117560&oldid=115092667

Nemo_bis added a comment.Jan 30 2014, 10:48 AM

That's expected behaviour, formatnum is trying to unformat according to Polish rules but you provided it with an English-formatted numbers. This is a core issue, invalid for Translate and duplicate of bug 35922 for core.

tomasz added a comment.Jan 30 2014, 11:01 AM

https://www.mediawiki.org/wiki/Help:Magic_words#Formatting suggests that the numbers are formatted according to the wiki's default locale, which in Commons's example is, I think, English.

Nikerabbit added a comment.Jan 30 2014, 11:02 AM

The problem is that CoreParserFunctions::formatRaw uses content language and not page language while formatnum raw excepts page language.

tomasz added a comment.Jan 30 2014, 11:06 AM

[Is this bug still invalid or duplicate?]

gerritbot added a comment.Jan 30 2014, 11:19 AM

Change 110342 had a related patch set uploaded by Nikerabbit:
Parser functions now format numbers according to page language

https://gerrit.wikimedia.org/r/110342

tomasz added a comment.Feb 3 2014, 9:44 PM

21:34 +logmsgbot: !log bsitu synchronized wmf-config/InitialiseSettings.php 'Enable Flow on two enwiki WikiProject pages'

tomasz added a comment.Feb 3 2014, 9:45 PM

Not this bug, obviously; please ignore comment 13.

tomasz unsubscribed.Mar 18 2016, 5:31 PM
Restricted Application added subscribers: Steinsplitter, Aklapper. · View Herald TranscriptMar 18 2016, 5:31 PM
gerritbot subscribed.Aug 11 2016, 12:05 PM

Change 110342 had a related patch set uploaded (by Nikerabbit):
Parser functions now format numbers according to page language

https://gerrit.wikimedia.org/r/110342

Nikerabbit claimed this task.Aug 11 2016, 12:06 PM
gerritbot added a comment.Oct 25 2016, 7:26 PM

Change 110342 merged by jenkins-bot:
Parser functions now format numbers according to page language

https://gerrit.wikimedia.org/r/110342

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.29-release (WMF-deploy-2016-11-01_(1.29.0-wmf.1)).Oct 25 2016, 8:00 PM
gerritbot added a comment.Oct 25 2016, 11:09 PM

Change 318012 had a related patch set uploaded (by Legoktm):
Parser functions now format numbers according to page language

https://gerrit.wikimedia.org/r/318012

gerritbot added a comment.Oct 25 2016, 11:22 PM

Change 318012 merged by jenkins-bot:
Parser functions now format numbers according to page language

https://gerrit.wikimedia.org/r/318012

Nemo_bis closed this task as Resolved.Oct 27 2016, 6:25 PM
Matanya mentioned this in T149840: [Bug] parser fatal : Catchable fatal error: Argument 3 passed to CoreParserFunctions::formatRaw() must be an instance of Language.Nov 2 2016, 8:03 PM
Arseny1992 reopened this task as Open.Nov 2 2016, 8:34 PM
Arseny1992 subscribed.

Reopenng due to T149840

gerritbot added a comment.Nov 3 2016, 8:04 AM

Change 319528 had a related patch set uploaded (by Nikerabbit):
Parser functions now format numbers according to page language (2nd attempt)

https://gerrit.wikimedia.org/r/319528

gerritbot added a comment.Dec 21 2016, 7:58 AM

Change 319528 merged by Nikerabbit:
Parser functions now format numbers according to page language (2nd attempt)

https://gerrit.wikimedia.org/r/319528

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), MW-1.29-release-notes.Dec 21 2016, 8:00 AM
Nikerabbit closed this task as Resolved.Dec 21 2016, 8:32 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL