Page MenuHomePhabricator

Make edit warning work even if CodeEditor is enabled
Closed, ResolvedPublic

Description

Steps to reproduce

  1. Enable the preference "Warn me when I leave an edit page with unsaved changes" at Special:Preferences#mw-prefsection-editing
  2. Go to https://en.wikipedia.org/wiki/Special:MyPage/common.js?action=edit
  3. Code something cool! (ok, for now just type "test" :-)
  4. Try to close the page

Expected result:
There should be a warning such as "Leaving this page may cause you to lose any changes you have made. If you are logged in, you can disable this warning in the "Editing" section of your preferences."

Actual result:
The page is closed without warning and you lose your work!

Browsers

  • Google Chrome 32
  • Firefox 26

Details

Reference
bz60615

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:56 AM
bzimport set Reference to bz60615.
bzimport added a subscriber: Unknown Object (MLST).

With which browser(s) did you test this?

Google Chrome 32.0.1700.102 and Firefox 26.0.

He7d3r renamed this task from Edit Warning doesn't work if CodeEditor is enabled to Make edit warning work even if CodeEditor is enabled.Aug 15 2015, 7:05 PM
He7d3r updated the task description. (Show Details)
He7d3r set Security to None.

Ehm, didn't I fix this a long time ago ?

@He7d3r, do you still experience this ?

He7d3r claimed this task.

Indeed. Looks like it is now working on Firefox/Chrome.