Page MenuHomePhabricator

Annotations from anonymous users can't be edited/deleted
Closed, DeclinedPublic

Description

Author: gabriel.birke

Description:
Annotations from anonymous users are stored with user id 0. However, the code for updating/deleting annotations checks for user id identity so even logged in users can only edit their own comments. This could result in undeleteable, uneditable offensive comments all over the wiki.

My proposal for this would be new permissions named "updateannotation" and "deleteannotation" assigned to the sysop user by default. These permissions would allow to bypass the "only update/delete your own annotation" restriction.


Version: unspecified
Severity: normal
See Also:
T54156: History for annotations
T56246: Logging for deleted annotations

Details

Reference
bz60616

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:56 AM
bzimport set Reference to bz60616.
bzimport added a subscriber: Unknown Object (MLST).

I think this makes sense. It fits the general naming convention (e.g. editusercss vs. editmyusercss).

Related note, until bug 52156 is fixed, there is no history or undeletion (which are quite important on a wiki).

Change 110932 had a related patch set uploaded by Chiborg:
New permissions for update/delete of annotations

https://gerrit.wikimedia.org/r/110932

MarcoAurelio subscribed.

Declining per T189753: Archive the Annotator extension. The extension is no longer maintained and has been archived.