Fatal error: Call to a member function getId() on a non-object in CourseTalkNotification.php on line 108
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Reedy
	Jan 30 2014, 7:10 PM

Description

[30-Jan-2014 19:06:49] Fatal error: Call to a member function getId() on a non-object at /usr/local/apache/common-local/php-1.23wmf11/extensions/EducationProgram/includes/notifications/CourseTalkNotification.php on line 108
Server: mw1173
Method: POST
URL: http://en.wikipedia.org/w/index.php?title=Education_Program_talk:University_of_California,_Berkeley/Cyberlaw_(Spring_2014)/Timeline&action=submit
Backtrace:
#0 /usr/local/apache/common-local/php-1.23wmf11/extensions/EducationProgram/includes/notifications/CourseTalkNotification.php(108): EducationProgram\CourseTalkNotification::trigger()
#1 /usr/local/apache/common-local/php-1.23wmf11/extensions/EducationProgram/includes/notifications/NotificationsManager.php(158): EducationProgram\CourseTalkNotification->trigger(Array)
#2 /usr/local/apache/common-local/php-1.23wmf11/extensions/EducationProgram/EducationProgram.hooks.php(590): EducationProgram\NotificationsManager->trigger('ep-course-talk-...', Array)
#3 [internal function]: EducationProgram\Hooks::onPageContentSaveComplete(Object(WikiPage), Object(User), Object(WikitextContent), '+sign ups', 0, NULL, NULL, 98, NULL, Object(Status), false)
#4 /usr/local/apache/common-local/php-1.23wmf11/includes/Hooks.php(206): call_user_func_array('EducationProgra...', Array)
#5 /usr/local/apache/common-local/php-1.23wmf11/includes/GlobalFunctions.php(4034): Hooks::run('PageContentSave...', Array, NULL)
#6 /usr/local/apache/common-local/php-1.23wmf11/includes/WikiPage.php(1975): wfRunHooks('PageContentSave...', Array)
#7 [internal function]: WikiPage->doEditContent(Object(WikitextContent), '+sign ups', 98, false, NULL, 'text/x-wiki')
#8 /usr/local/apache/common-local/php-1.23wmf11/includes/Article.php(2047): call_user_func_array(Array, Array)
#9 /usr/local/apache/common-local/php-1.23wmf11/includes/EditPage.php(1806): Article->__call('doEditContent', Array)
#10 /usr/local/apache/common-local/php-1.23wmf11/includes/EditPage.php(1806): Article->doEditContent(Object(WikitextContent), '+sign ups', 98, false, NULL, 'text/x-wiki')
#11 /usr/local/apache/common-local/php-1.23wmf11/includes/EditPage.php(1231): EditPage->internalAttemptSave(Array, false)
#12 /usr/local/apache/common-local/php-1.23wmf11/includes/EditPage.php(428): EditPage->attemptSave()
#13 /usr/local/apache/common-local/php-1.23wmf11/includes/actions/EditAction.php(50): EditPage->edit()
#14 /usr/local/apache/common-local/php-1.23wmf11/includes/actions/EditAction.php(74): EditAction->show()
#15 /usr/local/apache/common-local/php-1.23wmf11/includes/Wiki.php(441): SubmitAction->show()
#16 /usr/local/apache/common-local/php-1.23wmf11/includes/Wiki.php(305): MediaWiki->performAction(Object(Article), Object(Title))
#17 /usr/local/apache/common-local/php-1.23wmf11/includes/Wiki.php(599): MediaWiki->performRequest()
#18 /usr/local/apache/common-local/php-1.23wmf11/includes/Wiki.php(460): MediaWiki->main()
#19 /usr/local/apache/common-local/php-1.23wmf11/index.php(49): MediaWiki->run()
#20 /usr/local/apache/common-local/w/index.php(3): require('/usr/local/apac...')
#21 {main}

Version: unspecified
Severity: normal

Details

Reference: bz60633

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:57 AM

• bzimport added a project: MediaWiki-extensions-EducationProgram.

• bzimport set Reference to bz60633.

Reedy created this task.Jan 30 2014, 7:10 PM

public function trigger( $params ) {

		$revision = $params['revision'];

		\EchoEvent::create( array(
			'type' => CourseTalkNotification::KEY,
			'title' => $params['course-talk-title'],
			'agent' => $params['agent'],
			'extra' => array (

				// 'revid' is used by the EchoBasicFormatter (which
				// CourseTalkFormatter inherits from) to generate the diff
				// destination, which we use in the secondary link.
				'revid' => $revision->getId(),
			),
		) );

}

Not checking if there's actually a revision object...

andrew.green.df wrote:

https://gerrit.wikimedia.org/r/#/c/110446/

Fatal error: Call to a member function getId() on a non-object in CourseTalkNotification.php on line 108Closed, ResolvedPublicActions

Description

Details

Event Timeline

Fatal error: Call to a member function getId() on a non-object in CourseTalkNotification.php on line 108
Closed, ResolvedPublic
Actions