Page MenuHomePhabricator

LocalisationCache::readPHPFile should suppress warnings around ini_set
Closed, ResolvedPublic

Description

Some people have ini_set disabled, which sucks but we can't do anything about it. Having the ini_set call fail for disabling apc isn't that big a deal, so we should probably just hide the warning.

So need to put wfSuppressWarnings() before the ini_set call, and wfRestoreWarnings() after the ini_set call in LocalisationCache::readPHPFile


Version: unspecified
Severity: normal

Details

Reference
bz60658

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:59 AM
bzimport set Reference to bz60658.

jacob.jh.clark wrote:

Hi, I'd love to pick this bug up. Could it be assigned to me?

Jacob Clark.

jacob.jh.clark wrote:

This is now in gerrit awaiting code review: https://gerrit.wikimedia.org/r/#/c/110693/

Gerrit change 110693 has been merged.

Please, mention the bug in the commit message next time so it gets synced automatically in bugzilla.