Page MenuHomePhabricator

Flow: create browser test for permalink
Closed, ResolvedPublic

Description

From the Closing-the-barn-door-after-the-release-train-has-bolted department,
bug 60638 exposed we don't have a test for permalink.

It would be something like

Scenario: Follow a permalink
  Given I am on Flow page
  When I click the Permalink icon of a post
  Then the browser should load the post's topic
    And the post should scroll into view
    And the post should have a highlight

A [[wp:SMOP]], right? :)


Version: master
Severity: normal

Details

Reference
bz60659

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:59 AM
bzimport set Reference to bz60659.

About that barn door, we like to call those "regression tests" :-)

https://gerrit.wikimedia.org/r/#/c/112049/
https://gerrit.wikimedia.org/r/#/c/112049/

would be the best place to take up the conversation, but the Scenarios I think should look something like:

Scenario: Actions menu Permalink

Given I am on Flow page
When I click Actions menu for the Topic
  And I click Permalink from the Actions menu
  And I add 3 comments to the Topic
  And I click Actions menu for the 3rd comment on the Topic
  And I click Permalink from the Actions menu
Then the text of the 3rd comment on the Topic should be visible
  And the 3rd comment on the Topic should have a green bar on the left

Scenario: Actions menu History

Given I am on Flow page
  And I add a Topic
  And I add 3 comments to a Topic
When I click Actions menu for the Topic
  And I click History from the Actions menu
  And I click 3 comments were added
Then The comment history should be visible
  And the 3rd comment should have a green bar on the left.  (Note: this does not work as expected as of 7 Feb: https://bugzilla.wikimedia.org/show_bug.cgi?id=61046)

Chris wrote tests/browser/features/action_menu_permalink.feature , so I'm declaring this fixed.