Page MenuHomePhabricator

Mediawiki.ui buttons: active state is slightly bigger than disabled state due to border
Closed, InvalidPublic

Description

Try replying to any Flow post - e.g., this one: https://www.mediawiki.org/w/index.php?title=Talk:Sandbox&topic%5BpostId%5D=050f698e3f6e5624fa1590b11c27932f&workflow=050f698e3f6e5624fa1590b11c27932f

Before you start typing, when the button is not active, it's smaller than when you start typing and it becomes active – apparently due to a border that appears in the active state. In context, this causes the rest of the buttons in that row to jump a bit and generally looks a bit janky.


Version: master
Severity: normal

Details

Reference
bz60661

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:59 AM
bzimport set Reference to bz60661.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 14601
Different heights of .mw-ui-button.mw-ui-primary and .mw-ui-button

Same problem with button which hasn't any additional styles, just .mw-ui-button.

Attached:

mediawiki-ui-buttons.png (54×357 px, 4 KB)

(In reply to Sergey Leschina from comment #1)

Created attachment 14601 [details]
Different heights of .mw-ui-button.mw-ui-primary and .mw-ui-button

Same problem with button which hasn't any additional styles, just
.mw-ui-button.

Which wiki are you testing that on, and with what page? That is not the current styling for a plain mediawiki.ui.button (it's a little too dark, for one thing). Plain buttons now look like the attached.

More generally, this needs to be retested after Flow removes the custom overrides for core classes. It may be a problem with the Flow code, rather than core.

Attached:

mediawiki-ui-buttons.png (54×357 px, 4 KB)

Created attachment 14625
Plain mw-ui-button

A plain mw-ui-button to demonstrate core styling

Attached:

mw-ui-button_no_other_classes.png (47×153 px, 1 KB)

Comment #0 doesn't apply to the mediawiki.ui in core, since a disabled button has a gray background.

But comment #1 does apply to mediawiki.ui in core, neutral buttons are still bigger than the colored buttons, due to different border handling. I filed bug 62292 before noticing this one.

I don't think this bug is relevant anymore?