Page MenuHomePhabricator

Flow: post permalink URLs added a topic[postId] parameter
Open, MediumPublic

Description

A permalink on the old code on ee-flow-big instance is

http://ee-flow-big.instance-proxy.wmflabs.org/w/index.php?
title=Talk:Sandbox&
workflow=050b263a41bd4ba5b8c6fa163e1846b9
#flow-post-050f9884ce0ee46a90ebfa163e1846b9

i.e. just the topic and with a fragment to scroll the post into view (and highlight with JS).

By 1.23wmf13 a permalink becomes

https://www.mediawiki.org/w/index.php?
title=Talk:Sandbox&
topic[postId]=050f56f284d4d0411a91842b2b774fd8&
workflow=050f142239ecc14b3c5090b11c2789df
#flow-post-050f56f284d4d0411a91842b2b774fd8

The topic[postId] isn't currently required, is it there for future-proofing? e.g. if we paginate topics or split posts.


Version: master
Severity: minor

Details

Reference
bz60663

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:59 AM
bzimport set Reference to bz60663.
bzimport added a subscriber: Unknown Object (MLST).

Moreover, the "topic[postId]" breaks the links, as reported on
https://www.mediawiki.org/wiki/Thread:Extension_talk:Scribunto/Framework_for_interactive_applications_on-wiki/reply_%282%29

Are the user supposed to know that they need to replace "topic[postId]" by "%5BpostId%5D"?
(I used encodeURIComponent('[postId]') in the console to get this)

Should this encoding problem be reported in a new bug?

(In reply to comment #2)

Should this encoding problem be reported in a new bug?

Nope, that's already bug 56196 (patch to review). Thanks though :)

Splitting off posts is definitely something we want to do in the future, and we probably do need to keep paginating topics on standby as a possible feature - can't intelligently comment on the rest of the bug, but those are two potential product needs, yes :)