Page MenuHomePhabricator

mw-createaccount-cta needs to be one line
Closed, InvalidPublic

Description

Author: swalling

Description:
The change that resulted from bug 60605 caused an undesirable link break between the button and the text in the mw-createaccount-cta div.

These two elements were designed to be on the same line wherever possible. Having a new line for each element is unnecessary and distracting.


Version: 1.23.0
Severity: normal

Details

Reference
bz60700

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:01 AM
bzimport set Reference to bz60700.

Does it? It's not in most languages.

swalling wrote:

(In reply to comment #1)

Does it? It's not in most languages.

It is ideally supposed to be one line, but we can't control the length of a translation. en, pl, zh, and others have one line. Other languages (es, pt, ja, fr, de etc.) have two because of the string length.

We can't accommodate all the lengthy translations because you don't want a CTA below a form to be wider than the form itself. If we absolutely want to enforce no line break in the cta, then the proper resolution is to resolve bug 47392 by moving the cta to the right of the form and remove mw-ui-vform's restriction of width: 290px;. That is okay with me, but in the interim it should not be that hard to prevent an unnecessary line break if the text is short enough.

This has been invalidated by the recent design changes per T85189. The form now looks like this:

pasted_file (546×342 px, 24 KB)