Page MenuHomePhabricator

VisualEditor: Providing clearer errors about invalid media item sizes on new Media Settings>Advanced Settings
Open, LowPublicFeature

Description

Right now, if I add an image for example:https://test2.wikipedia.org/wiki/File:Foo.jpg

Initially in VE from Insert>Media it renders as 229x150.
If a user attempts to resize it to 350x350 , it will show a message that "Size Values are invalid" as it has exceeded the original dimension values.But unless user knows those original dimensions , he or she might keep trying with different values not knowing what should be the input limit.

I think it will be better if we can have more clearer indication in the message saying something like "the size values are invalid since it has exceeded original dimension"


Version: unspecified
Severity: enhancement

Details

Reference
bz60705

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:02 AM
bzimport set Reference to bz60705.

We should probably have several errors:

  • "Size can be up to <width>x<height> pixels." (if too big for media)
  • "Size must be positive whole numbers." (if not valid, e.g. negative or "hello")
  • "Size is limited to <maxsize> pixels." (if SVGMaxSize reached)

Should those block the 'apply' button, or just give an indication that the size itself won't be applied, giving the user the option to apply the rest of the properties?

(In reply to comment #2)

Should those block the 'apply' button, or just give an indication that the
size itself won't be applied, giving the user the option to apply the rest
of the properties?

The second – see bug 60602.

Jdforrester-WMF lowered the priority of this task from High to Medium.Jan 9 2015, 10:55 PM
Deskana lowered the priority of this task from Medium to Low.May 3 2018, 8:16 AM
Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 11:13 AM
Aklapper removed a subscriber: rmoen.