Page MenuHomePhabricator

Remove Easter egg from conf/highlight.php
Closed, ResolvedPublic

Description

[1] shows a $secretSitePassword, looking at the (public) code at [2] gives a comment "Easter egg". In my opinion this is very confusing, because some people who see this, can think about a secret problem, so please remove the easter egg and give better explain what the user should do or has done wrong when viewing the highlight.php without a param. Thanks.

[1] https://noc.wikimedia.org/conf/highlight.php
[2] https://git.wikimedia.org/blob/operations%2Fmediawiki-config/c815099256d9669aded81b6efca721e7e57c9965/docroot%2Fnoc%2Fconf%2Fhighlight.php#L43


Version: wmf-deployment
Severity: normal

Details

Reference
bz60741

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:04 AM
bzimport set Reference to bz60741.
bzimport added a subscriber: Unknown Object (MLST).

Change 110874 had a related patch set uploaded by Se4598:
Replace easter egg by a more explaining message

https://gerrit.wikimedia.org/r/110874

I don't think there's consensus to remove this Easter egg for now. Though making the fake password longer would be nice. The current password looks a bit too short to be real. :-)

no consensus :)

Odder 22:20
I for one think the patch is valid.

As much as I like easter eggs, this particular one leads to people making requests such as linked to by Se4598, which in itself is a waste of our volunteers' precious time.

Matanya 22:24
i'm with odder here.

Change 110874 merged by Ori.livneh:
Replace easter egg by a more explaining message

https://gerrit.wikimedia.org/r/110874

Vote was 3 against 2 for the easter egg, but then suddenly Ori:
"Oh no, someone hacked my Gerrit account and merged this change"

  • end of story --

Change 110926 had a related patch set uploaded by Hashar:
Replace easter egg by a more explaining message

https://gerrit.wikimedia.org/r/110926

This was merged & deployed by Tim ages ago.