Previously, the edit pencil didn't errantly show on Wikipedia Zero due to the current lack of HTTPS support. Now it is showing again.
Version: unspecified
Severity: normal
Description
Description
Details
Details
- Reference
- bz60774
Event Timeline
Comment Actions
dr0ptp4kt some more detail would help - this doesn't make much sense to me and I know MobileFrontend pretty well - how are you disabling editing in Zero? It would make more sense to alter the skin if you are not doing so already. If you have a CSS/JS hack that is bad...
Comment Actions
Created attachment 14457
Edit pencil while on a W0 partner network
This is from the simulator, but is reproducible in iOS 7 on a real device.
Attached:
Comment Actions
Created attachment 14458
Edit pencil - login
Note no interstitial was shown.
Attached:
Comment Actions
Created attachment 14459
Edit pencil - login page, no banner, no interstitial
Note that tapping on Login yields a page without W0 banner, sadly without an interstitial beforehand.
Attached:
Comment Actions
The per-section edit pencil was IIRC added to the page dynamically, so it was suppressed with a combination of CSS and JS. I'm guessing something about the event firing model or CSS style changed.
The HTML is going to be identical across carriers on a per-language basis, even though certain features will only be available depending on carrier capabilities.
Which skin would you recommend updating? Superclass or not? It sounds like we'd still need to always apply page runtime JS stuff to modify the edit thing, but like you mentioned in our face to face, maybe there's a way to wrap edit icons in a tag, thereby making it easier to enable/disable depending on carrier capabilities.