Page MenuHomePhabricator

Database lock time out when renaming an account with 180,000+ edits
Closed, ResolvedPublic

Description

An account was renamed on the Dutch Wikipedia (Wikix -> Wikix-oud; Wwikix -> Wikix) due to the original user not being able to login anymore. He forgot his password after he changed it a few times. Wikix has 180,000+ edits, see the rename logs: https://nl.wikipedia.org/w/index.php?title=Speciaal%3ALogboeken&type=renameuser&user=CaAl&page=&year=&month=-1&tagfilter=

The bureaucrat got an error when renaming this account: "database lock time out, please try again". Wikix said he can't login as Wikix so there definitely went something wrong. See also https://nl.wikipedia.org/wiki/Wikipedia:Verzoek_voor_hernoeming_van_account#Wwikix_.E2.86.92_Wikix


Version: unspecified
Severity: major

Details

Reference
bz60798

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:51 AM
bzimport set Reference to bz60798.
bzimport added a subscriber: Unknown Object (MLST).

This might more appropriately be a Wikimedia bug. Or perhaps two bugs?

Any update on this? He still can't login on Wikix (and uses Wwikix now).

CC'ing Sean and Brad (database / login territory, though this is user renaming) - wondering if they can help (or know better-suited devs)

(In reply to Andre Klapper from comment #3)

CC'ing Sean and Brad (database / login territory, though this is user
renaming) - wondering if they can help (or know better-suited devs)

I see a log entry for the lock failure (dberror.log-20140203.gz on fluorine):

Sun Feb 2 12:35:26 UTC 2014 mw1083 nlwiki RenameuserSQL::rename 10.64.16.25 1205 Lock wait timeout exceeded; try restarting transaction (10.64.16.25) UPDATE user SET user_name = 'Wikix-oud',user_touched = '20140202123435' WHERE user_name = 'Wikix' AND user_id = '9284'

Looking at the code, it seems that that failure was in the first SQL query for the rename, and should have caused the rest of the rename process not to proceed.

The log entry that is showing up at https://nl.wikipedia.org/w/index.php?title=Speciaal%3ALogboeken&type=renameuser&user=CaAl&page=&year=&month=-1&tagfilter has a timestamp of 2014-02-02 12:35:50.

I wonder whether CaAl had accidentally hit the submit button twice, so the first submission went through while the second timed out waiting on the first.

I also see that the account with user_id 9284 is currently named "Wikix-oud" with a last touched timestamp of 2014-02-02 12:46:50, then there are also both "Wikix" and "Wwikix" users. Both Wikix and Wwikix appear to have email addresses set (slightly different ones) and validated. So the user should be able to recover the password for the nlwiki Wikix account in the normal way unless he no longer has access to that email address for some reason. Wikix-oud has no email set, which I suppose is the reason for the rename in the first place.

SUL-wise, I see that the Wikix user is not attached to the global Wikix account. Which is to be expected since nlwiki's Wikix was renamed and then Wwikix was renamed into its place.

I don't know of any of that was helpful.

Now that revisions are associated with actors instead of a user id directly, this shouldn't happen any more

Pppery subscribed.

Now that revisions are associated with actors instead of a user id directly, this shouldn't happen any more