As of T47677 and https://github.com/cssjanus/cssjanus/pull/44, CSSjanus supports flipping shadows. However, if a rule declares multiple shadows, it flips only the first shadow.
Description
Details
- Reference
- bz60805
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T62805 Support flipping mutiple values under a text-shadow or border-shadow rule | |||
Resolved | matmarex | T47677 CSSJanus: box-shadow and text-shadow should be flipped in RTL |
Event Timeline
(In reply to comment #0)
It flipped the y-offset for some reason:
ltr: text-shadow: #333333 0px -1px 1px, #FFFFFF 0px 2px 1px;
rtl: text-shadow: #333333 0px 1px 1px, #FFFFFF 0px 2px 1px;
When you say "it flipped," what is "it"?
Is this a ResourceLoader bug?
See the numbers in the rule? The -1 became a 1. It flipped.
Is resourceloader what flips the interface for rtl languages?
(In reply to comment #2)
See the numbers in the rule? The -1 became a 1. It flipped.
Yes, the CSS changed (flipped), but what changed it? Where did you see this? What were you doing when this happened? Are there exact steps to reproduce?
I don't know; where does mw flip the interface css for rtl languages?
I was juggling ostriches on the moon at the time. I suppose to reproduce it you would have to go to the moon and juggle ostriches, then. Oh, and put something like what I pasted above in a file that gets flipped, probably. Unless it really was the ostriches what did it? Now there's a thought.
(In reply to comment #0)
ltr: text-shadow: #333333 0px -1px 1px, #FFFFFF 0px 2px 1px;
rtl: text-shadow: #333333 0px 1px 1px, #FFFFFF 0px 2px 1px;
There are two shadows defined here, and ResourceLoader (or actually CSSJanus) only supports flipping the first one in a rule right now. :(
I added the half-baked feature in I97ee7431 to fix bug 45677.
(Rephrasing the summary and moving to a better component.)
I can't reproduce this in the latest version of CSSJanus.
Also verified with MediaWiki that this rule is not flipped.
That test case is flawed, because the value being flipped is the '0px', which when flipped is still '0px'. https://cssjanus.github.io/#input/.foo%20%7B%0A%20text-shadow%3A%20%23333333%2099px%20-1px%201px%2C%20%23FFFFFF%2099px%202px%201px%3B%0A%7D
@matmarex Can you make sure this is reported in the CSSJanus issue tracker, and link it from the task description?