Page MenuHomePhabricator

Better hashing for IP addresses on Event Logging
Closed, ResolvedPublic

Description

The current behavior when hashing IP addresses on Event Logging is to generate a 'salt' (really a key) at runtime and to
use it continuously for the lifetime of the program. The lifespan of the key
and the cheapness of the hash function make it easier to attack.

Per security's team request we should be making EventLogging scramble IPs by generating an HMAC SHA1 with the IP address
as the message and a random byte string as the key. The key rotates every 90
days.


Version: unspecified
Severity: normal

Details

Reference
bz60832

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:53 AM
bzimport set Reference to bz60832.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/analytics/cards/cards/1430

Changes to this regard were already done. This bug can be closed.