Page MenuHomePhabricator
Create Task
Maniphest T62843

VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element
Closed, ResolvedPublic
Actions

Description

link text appearing for the second time

Steps to reproduce:

1.Select a math function/image/gallery/hiero
2.Now open the link inspector
3.Insert a link (this link gets placed just before the selected element)
4.Again select the element
5.Open the link inserter
6.Observe that the link title of the previous link is appearing now in the link inspector
7.Close the link inspector.

Observed Result:
The link text title of the previous link is getting inserted just before the selected element.

See the screenshot attached.

Test Environment: https://test2.wikipedia.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5
Page:https://test2.wikipedia.org/wiki/Image_then_gallery?veaction=edit

Version: unspecified
Severity: normal

Attached:

Screen_Shot_2014-02-04_at_11.53.10_AM.png (128×579 px, 12 KB)

Details

Reference
bz60843

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 2:54 AM
• bzimport added projects: VE-deploy-2014-09-18, VisualEditor-EditingTools.
• bzimport set Reference to bz60843.
Ryasmeen created this task.Feb 4 2014, 8:06 PM
Ryasmeen added a comment.Feb 4 2014, 8:07 PM

Created attachment 14487
link text getting added before math function

Attached:

Screen_Shot_2014-02-04_at_11.48.47_AM.png (515×1 px, 129 KB)

gerritbot added a comment.Jun 12 2014, 12:42 AM

Change 138114 had a related patch set uploaded by Catrope:
[BREAKING CHANGE] Update VE core submodule to master (43a48cb) for window process cleanup

https://gerrit.wikimedia.org/r/138114

gerritbot added a comment.Jun 12 2014, 12:44 AM

Change 138114 merged by jenkins-bot:
[BREAKING CHANGE] Update VE core submodule to master (43a48cb) for window process cleanup

https://gerrit.wikimedia.org/r/138114

Ryasmeen added a comment.Jun 13 2014, 10:57 PM

This is not yet fixed.The link text is still getting added next to the previously added link

Jdforrester-WMF added a comment.Jul 21 2014, 7:02 PM

Selection's not being re-set to the actual link (of the pre-annotation stack or something odd)?

Jdforrester-WMF added a comment.Jul 23 2014, 7:48 PM

Roan says the fix is to fix the pre-population of the link inspector in create mode. I think.

Catrope added a comment.Aug 22 2014, 6:57 AM

I think this is fixed now? I can't reproduce it any more...

Jdforrester-WMF added a comment.Aug 22 2014, 6:37 PM

Confirmed fixed in master but not in wmf18.

Catrope added a comment.Aug 22 2014, 6:40 PM

Never mind, I'm an idiot. It's still broken if you try to inspect the same reference with the link inspector twice in a row.

matmarex added a comment.Sep 17 2014, 11:56 AM

I can't reproduce. Probably fixed by Ed's recent cleanup of the link inspector.

Ryasmeen added a comment.Sep 17 2014, 7:20 PM

Verified the fix in Betalabs

Ryasmeen added a comment.Sep 18 2014, 11:21 PM

Verified the fix in test2

Ryasmeen added a comment.Sep 25 2014, 9:55 PM

Verified the fix in production

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 1:48 AM
Jdforrester-WMF added a project: VisualEditor-MediaWiki-Links.Jan 27 2015, 11:52 PM
Jdforrester-WMF removed a parent task: T50789: VisualEditor: Improvements and behaviour changes to the link input widget (tracking).Sep 10 2015, 6:56 PM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 10 2015, 7:06 PM
Jdforrester-WMF set Security to None.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL