Page MenuHomePhabricator
Create Task
Maniphest T62904

Notify the user when there are new messages to translate
Closed, DuplicatePublic
Actions

Description

It would be desirable to be able to add a message group to your watchlist (for a given language).

This would allow translators to add e.g. a fundraising banner to their watchlist in order to quickly get a notification if any new/extra translation is needed.

The current mechanism only allows a user to add each individual source message meaning messages added to the group would not trigger a notification.

Watchlist should be triggered either by changes in the message group state for the selected language. I.e. by anything changing the percentage of translated/outdated messages.

Details

Reference
bz60904
SubjectRepoBranchLines +/-
Added a watch/unwatch option to the Special:Translatemediawiki/extensions/Translatemaster+384 -4
Added API query to get message group watchlist information.mediawiki/extensions/Translatemaster+106 -35
Added a watch/unwatch option to the Special:Translatemediawiki/extensions/Translatemaster+290 -4
Add star icon to message group watchingmediawiki/extensions/Translatemaster+119 -15
WIP Add API for message group watchlistmediawiki/extensions/Translatemaster+220 -3
Added a watch/unwatch option to the Special:Translatemediawiki/extensions/Translatemaster+139 -160
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 2:58 AM
• bzimport added a project: MediaWiki-extensions-Translate.
• bzimport set Reference to bz60904.
• bzimport added a subscriber: Unknown Object (MLST).
Lokal_Profil created this task.Feb 5 2014, 3:47 PM
siebrand added a comment.Apr 22 2014, 9:23 AM

Amir, I see you are changing priorities. Does this mean that as a product manager, you're going to put resources to fixing this issue? If so, can you please indicate where I can see how this issue is being treated on your backlog?

Nemo_bis awarded a token.Dec 12 2014, 8:19 AM
Nikerabbit lowered the priority of this task from High to Medium.Jan 26 2015, 9:22 PM
Nemo_bis added a subtask: T90133: Syndicated feed of translations [per language and group].Feb 22 2015, 7:12 PM
• Tbayer subscribed.May 26 2015, 8:42 PM
Nikerabbit updated the task description. (Show Details)Apr 20 2016, 12:05 PM
Nikerabbit removed a subscriber: • wikibugs-l-list.
Amire80 merged a task: T159642: notify the user when there are new messages to translate.Apr 23 2017, 11:54 AM
Amire80 added a subscriber: Aklapper.
Nikerabbit renamed this task from Adding message group to watchlist to Notify the user when there are new messages to translate.Apr 25 2017, 8:42 AM
Amire80 assigned this task to Anna.d92.May 14 2017, 9:58 AM
Amire80 added subscribers: Anna.d92, Roni.zhelenchuk.

I am working with @Anna.d92 and @Roni.zhelenchuk to resolve this, as part of their project in the Hebrew University.

Liuxinyu970226 subscribed.May 14 2017, 1:15 PM
Amire80 mentioned this in T165241: Consider removing the title "Message group" that appears inside the group selector.May 15 2017, 8:22 AM
• Elitre awarded a token.May 15 2017, 11:44 AM
Nemo_bis mentioned this in T90133: Syndicated feed of translations [per language and group].Oct 27 2017, 7:11 AM
Amire80 added a comment.Mar 11 2018, 12:34 PM

I met @Anna.d92 and @Roni.zhelenchuk and we discussed some ideas about implementation and timeline. Here's the summary. Feedback is welcome, especially from @Nikerabbit.

  • Backend
    • How will the watched projects / message groups be stored?
      • One solution: Add a new db table similar to the watchlist table in core. The fields will be:
        • twl_id
        • twl_user
        • twl_message_group
        • twl_notificationtimestamp
      • Another solution:
        • Something in the user preferences?..
    • Will this be different between message groups for software projects and translatable pages?
      • A translatable page is just a wiki page and can (probably) be watched with the usual watchlist.
      • Perhaps an aggregate group of translated pages can be watched as a project?
    • When is the notification sent?
      • Initiated by the updating script?
      • (Probably better:) Identified by MediaWiki / Translate, without dependency on translatewiki scripts
      • (This should probably be as close as possible to how it works with the core page watchlists.)
    • How is it sent:
      • Notifications extension? (a.k.a. Echo)
        • Probably preferable
        • It will be useful to make it possible to connect this not only to email and notification indicators in the personal bar, but also propagate it to bots on Telegram, IRC, etc.
      • A separate notification or email system? (Probably less good)
  • Frontend:
    • How do we add a project to the watchlist and remove it?
      • A star near the project selector, similar to the watchlist star?
        • Near the breadcrumbs at the top?
        • Or near each message group row in the project selector?
      • Should we make editing the “raw” watchlist possible, like in the core MediaWiki? (probably low priority)
  • Project plan:
    • Preparation:
      • Make sure MediaWiki core and Translate extensions are installed and up to date
      • Have Gerrit accounts
    • Development:
      • Create a variable that enables the project watchlist feature (e.g. wgTranslateProjectWatchlist). Should be disabled by default, at least in the beginning, to allow development and testing.
      • Add the new database table creation script to Translate/sql, and make sure that it runs in update.php
      • Create an API to add to the watchlist and remove from the watchlist
        • A lot can probably be copied from <core>/includes/api/ApiWatch.php
      • Test at Special:ApiSandbox
      • Add the watchlist star (or whatever other design solution…)
      • Implement notification
        • (See above: Triggered form the script? Or triggered by a job inside MediaWiki/Translate while updating the message groups)
      • Add editing watchlist / raw watchlist
        • Learn from <core>/includes/specials/SpecialEditWatchlist.php
    • Deployment:
      • (at some point in the near future, when the basics are done): Deploy to dev.translatewiki.net
      • (at some later point after testing at dev): Deploy to the real translatewiki.net
      • (at some later point): Deploy to meta, mediawiki.org, etc.
Nikerabbit added a comment.Mar 12 2018, 8:45 AM

The database table needs a primary key, is that twl_id with autoincrement?

Create an API

These days you must specify whether this is PHP class/interface, action API or rest API :)

When is the notification sent?

One can hook into MessageIndex::rebuild – in fact there is even a hook TranslateEventMessageMembershipChange. I suggest to review carefully that part of code to make sure it is correct and does what is wanted – preferably by adding some unit tests. When using it I would recommend to code defensively add some sanity checks to avoid sending a flood of notifications, for example if we lose the cache and have to rebuild from scratch and treat everything as new.

How is it sent

Echo is the best option here. I see no reason to re-invent that wheel.

gerritbot subscribed.Apr 29 2018, 2:12 PM

Change 429656 had a related patch set uploaded (by Anna.d92; owner: Anna.d92):
[mediawiki/extensions/Translate@master] WIP Add API for message group watchlist

https://gerrit.wikimedia.org/r/429656

gerritbot added a project: Patch-For-Review.Apr 29 2018, 2:12 PM
• Elitre rescinded a token.May 2 2018, 9:24 AM
• Elitre awarded a token.
gerritbot added a comment.May 18 2018, 1:57 PM

Change 433716 had a related patch set uploaded (by Anna.d92; owner: Anna.d92):
[mediawiki/extensions/Translate@master] Added a watch/unwatch option to the Special:Translate

https://gerrit.wikimedia.org/r/433716

Amire80 mentioned this in T195048: Add a Telegram frontend for Echo notifications.May 19 2018, 10:50 AM
gerritbot added a comment.May 19 2018, 10:58 AM

Change 433935 had a related patch set uploaded (by Nikerabbit; owner: Anna.d92):
[mediawiki/extensions/Translate@master] Add star icon to message group watching

https://gerrit.wikimedia.org/r/433935

gerritbot added a comment.May 19 2018, 6:26 PM

Change 434042 had a related patch set uploaded (by Anna.d92; owner: Anna.d92):
[mediawiki/extensions/Translate@master] Added a watch/unwatch option to the Special:Translate

https://gerrit.wikimedia.org/r/434042

gerritbot added a comment.May 19 2018, 6:29 PM

Change 433716 abandoned by Anna.d92:
Added a watch/unwatch option to the Special:Translate

Reason:
Done in https://gerrit.wikimedia.org/r/#/c/434042/

https://gerrit.wikimedia.org/r/433716

gerritbot added a comment.May 19 2018, 6:29 PM

Change 429656 abandoned by Anna.d92:
WIP Add API for message group watchlist

Reason:
Done in https://gerrit.wikimedia.org/r/#/c/434042/

https://gerrit.wikimedia.org/r/429656

gerritbot added a comment.May 19 2018, 6:29 PM

Change 433935 abandoned by Anna.d92:
Add star icon to message group watching

Reason:
Done in https://gerrit.wikimedia.org/r/#/c/434042/

https://gerrit.wikimedia.org/r/433935

gerritbot added a comment.May 19 2018, 8:26 PM

Change 434100 had a related patch set uploaded (by Anna.d92; owner: Anna.d92):
[mediawiki/extensions/Translate@master] Added API query to get message group watchlist information.

https://gerrit.wikimedia.org/r/434100

gerritbot added a comment.May 19 2018, 10:58 PM

Change 434113 had a related patch set uploaded (by Amire80; owner: Anna.d92):
[mediawiki/extensions/Translate@master] Added a watch/unwatch option to the Special:Translate

https://gerrit.wikimedia.org/r/434113

Smalyshev subscribed.May 20 2018, 2:42 PM
gerritbot added a comment.Jan 22 2020, 9:31 AM

Change 434042 abandoned by Nikerabbit:
Added a watch/unwatch option to the Special:Translate

Reason:
Stale patch. See also https://translatewiki.net/wiki/Translating:DiscordWikiBot which can notify about new messages available for translation.

https://gerrit.wikimedia.org/r/434042

gerritbot added a comment.Jan 22 2020, 9:32 AM

Change 434100 abandoned by Nikerabbit:
Added API query to get message group watchlist information.

Reason:
Stale patch. See also https://translatewiki.net/wiki/Translating:DiscordWikiBot which can notify about new messages available for translation.

https://gerrit.wikimedia.org/r/434100

• Elitre unsubscribed.Jan 22 2020, 12:22 PM
Lokal_Profil awarded a token.Jan 22 2020, 8:16 PM
Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Mar 1 2020, 7:29 AM

@Anna.d92: Hi! This task has been assigned to you a while ago. Could you maybe share an update? Do you still plan to work on this task?
If you do not plan to work on this task anymore: Please consider removing yourself as assignee (via Add Action... → Assign / Claim in the dropdown menu): That would allow others to work on this (in theory), as others won't think that someone is already working on this. Thanks! :)

Amire80 removed Anna.d92 as the assignee of this task.Mar 1 2020, 9:06 AM

I don't think @Anna.d92 is going to work on it.

There's https://tools.wmflabs.org/watch-translations/ now, which does kind of something similar to what this task asks for, although it should remain open because it's probably better to do it inside Translate.

gerritbot added a comment.Jul 1 2020, 12:18 PM

Change 434113 abandoned by Amire80:
Added a watch/unwatch option to the Special:Translate

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/ /434113

Nikerabbit closed subtask T90133: Syndicated feed of translations [per language and group] as Declined.Sep 12 2022, 11:53 AM
Nikerabbit moved this task from Backlog to tux on the MediaWiki-extensions-Translate board.Sep 26 2022, 11:48 AM
abi_ closed this task as a duplicate of T348501: Minimal prototype implementation for watching message groups.Mon, Apr 15, 11:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL