| Legoktm | |
| Feb 5 2014, 4:54 PM |
| F13060: patch.diff | |
| Nov 22 2014, 2:58 AM |
See url, also screenshot provided by a user: http://i.imgur.com/2Vsq8V8.png.
Not sure what caused it, but it shouldn't break Echo because the notification can't be formatted.
Version: unspecified
Severity: critical
URL: https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Flow&oldid=594065615#Flow_.2B_Echo_.3D_Error.3F
\Flow\NotificationFormatter::getLinkParams calls \Flow\UrlGenerator::generateUrlData which is throwing InvalidInputException's.
Created attachment 14496
Patch
Hack-ish patch, but fixes the bug. Someone who knows this part of the code better could probably come up with a better fix.
Attached:
Change 111484 had a related patch set uploaded by EBernhardson:
Catch exceptions formatting notifications
Also https://gerrit.wikimedia.org/r/#/c/111495/ Echo change to prevent insertion of too much stuff.
Change 111625 had a related patch set uploaded by EBernhardson:
Prevent fatal errors in urlgenerator
Change 111614 had a related patch set uploaded by Matthias Mullie:
(bug 60906) Truncate content before storing event into DB
Change 111649 had a related patch set uploaded by Matthias Mullie:
(bug 60906) Truncate content before storing event into DB
Change 111614 abandoned by Matthias Mullie:
(bug 60906) Truncate content before storing event into DB
Reason:
Pushed anew, against master
Change 111654 had a related patch set uploaded by EBernhardson:
Catch exceptions formatting notifications
Change 111656 had a related patch set uploaded by EBernhardson:
Catch exceptions formatting notifications
Change 111658 had a related patch set uploaded by EBernhardson:
Prevent fatal errors in urlgenerator
Change 111659 had a related patch set uploaded by EBernhardson:
Prevent fatal errors in urlgenerator
deployed to 1.23wmf11 and 1.23wmf12. There is still a minor inconsistency, notifications that fail rendering will stay 'unread'
Change 111706 had a related patch set uploaded by Legoktm:
Don't throw exceptions in the Echo formatter
Change 111706 abandoned by Legoktm:
Don't throw exceptions in the Echo formatter
Reason:
I didn't mean to commit this...
Change 111649 merged by jenkins-bot:
(bug 60906) Truncate content before storing event into DB
Change 112730 had a related patch set uploaded by EBernhardson:
(bug 60906) Truncate content before storing event into DB
Change 112730 merged by jenkins-bot:
(bug 60906) Truncate content before storing event into DB