Page MenuHomePhabricator

VisualEditor: Format action applies to nodes inside handlesOwnChildren node
Closed, ResolvedPublic

Description

  1. Select a block image with caption
  2. Press the list button

Expected:
Either nothing, or a list is created above/below the image

Observed:
The caption is wrapped in a list

Clearly we need to ignore nodes which are inside handlesOwnChildren nodes when applying such actions.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=60804

Details

Reference
bz60969

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:02 AM
bzimport set Reference to bz60969.

Change 111822 had a related patch set uploaded by Esanders:
Don't descend into handlesOwnChildren nodes in selectNodes

https://gerrit.wikimedia.org/r/111822

I'm assuming that bug 60804 the same issue.

Change 111822 merged by jenkins-bot:
Don't descend into handlesOwnChildren nodes in selectNodes

https://gerrit.wikimedia.org/r/111822