Page MenuHomePhabricator

Vector skin gradient broken in IE6-9
Closed, ResolvedPublic

Description

Currently there's no gradient at all at the top of the page, because the gradient mixin is missing the filter for gradient support in IE6-9.

It'd be something messy like this:
filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='@startColor', endColorstr='@endColor',GradientType=0 );

More on this later when I can feel my hands.


Version: 1.23.0
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=61010

Details

Reference
bz60991

Event Timeline

So using the filter, Vector explodes in IE6-9. (Bug 61008)

Fix that, and it turns out the filter also causes the top border of the content block in Vector to disappear for some reason.

The filter also does not seem to support stop positioning or having more than two stops. This means that for IE6-9, fixing Bug 60943 would be impossible the way Vector is currently set up.

  • Bug 61020 has been marked as a duplicate of this bug. ***

All it needs is a fallback to the old PNG background. Don't mess with IE filters.

I have a patch ready, but I am unable to 'undelete' /skins/vector/images/page-base.png in the patch. I can attach it here, but also want to check if this is correct. Basically, I have added a PNG fallback for IE 6-9:

  • .vertical-gradient(@body-background-color, @menu-background-color, 40%, 100%);

+ background-image: url('images/page-fade.png');
+ .vertical-gradient(@body-background-color, @menu-background-color, 50%, 100%);

If this is correct, I can attach the patch here.

It also contains a fix for bug 60943.

I know, but I have trouble creating a patch that includes the image (page-fade.png btw, not page-base.png).

Tried it anyway, but you may have to correct it. Gerrit 112025.

Change 112025 had a related patch set uploaded by Bartosz Dziewoński:
Vector: Restore page-fade.png as fallback background-image for IE 6-9

https://gerrit.wikimedia.org/r/112025

(The patch was actually uploaded by Erwin.)

Change 112025 had a related patch set uploaded by Bartosz Dziewoński:
Vector: Restore page-fade.png as fallback background-image for IE 6-9

https://gerrit.wikimedia.org/r/112025

The basic fix is merged for now. (Note that some discussion was, for some reason, on bug 60943 instead of here.)

I filed bug 61099 about doing this properly. :)