Page MenuHomePhabricator

wgMFIsUserBlocked = true for non-blocked editors
Closed, ResolvedPublic

Description

When I try and edit any page on mobile I get the message "Your account is blocked from editing."

This is because
wgMFIsUserBlocked = true

I'm not sure why this value is true as it simply returns the result of Skin->getUser()->getBlocked() and my account is not blocked.


Version: unspecified
Severity: critical

Details

Reference
bz60993

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:04 AM
bzimport set Reference to bz60993.
bzimport added a subscriber: Unknown Object (MLST).

Also when I am logged out and go to
https://en.m.wikipedia.org/wiki/Arist%C3%B3fanes
If I click edit then I also get the message "Your account is
blocked from editing."

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1675

user->isBlocked might return true for a logged in user who's IP is blocked it seems. Oh dear.

Change 111899 had a related patch set uploaded by Jdlrobson:
Limit blocked test to logged in users.

https://gerrit.wikimedia.org/r/111899

Fixed. This was caused by an autoblock related to a single user on en.wiki. Apparently the autoblock must have hit some IP related to en.m.wikipedia.org.

I'm reopening this as the root cause of this issue has not yet been resolved. If it happened for this one user, it's only time until it happens again unless we resolve the underlying issue. From Brion:

"It's possible that some IP address in the load balancer or caching proxy chain on the mobile side isn't properly being registered as a trusted IP, and is getting blocked, thus blocking all editors who trigger things through the wrong path.

I strongly recommend that someone do a little checking in the database, or run a CheckUser on the account that got blocked to check which IPs were recorded and ended up being autoblocked, so we can make sure it doesn't repeat..."

I'm tentatively reclosing this as fixed. Like Jon mentioned in IRC, after some debugging this does not appear to be a MobileFrontend issue. Max deployed a potential fix, though current status is unclear: https://gerrit.wikimedia.org/r/#/c/111927/

If the issue is still ongoing, an RT ticket should be opened for ops.

Change 111899 merged by jenkins-bot:
Limit blocked test to logged in users.

https://gerrit.wikimedia.org/r/111899