Page MenuHomePhabricator

cosmetic changes must not remove useless spaces inside templates
Closed, ResolvedPublic

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:06 AM
bzimport set Reference to bz61024.

I'd guess not so: CosmeticChangesToolkit.removeUselessSpaces should not replace spaces inside of templates.

This behavior should be optional - for cs.wiki I want to remove "useless" spaces

'template' is in the exceptions list; maybe the exceptions regex doesn't work as expected for templates

Change 224301 had a related patch set uploaded (by Xqt):
Deactivate removeUselessSpaces due to several bugs

https://gerrit.wikimedia.org/r/224301

The replaceExcept 'template' handler was rewritten in 13cd73de7ac9244f67bc33a27e7278b9d48abbd3#3e3bbe17, and the 'nested' part is no longer complicated.

Change 226531 had a related patch set uploaded (by John Vandenberg):
Reduce complexity of NESTED_TEMPLATE_REGEX

https://gerrit.wikimedia.org/r/226531

Change 224301 abandoned by Xqt:
Deactivate removeUselessSpaces due to several bugs

https://gerrit.wikimedia.org/r/224301

Change 226531 merged by jenkins-bot:
Fix NESTED_TEMPLATE_REGEX

https://gerrit.wikimedia.org/r/226531

Reopened again. It doesn't work for nested templates.

Change 299137 had a related patch set uploaded (by Xqt):
Deactivate removeUselessSpaces due to several bugs

https://gerrit.wikimedia.org/r/299137

Change 299137 merged by jenkins-bot:
Deactivate removeUselessSpaces due to several bugs

https://gerrit.wikimedia.org/r/299137

Xqt raised the priority of this task from Medium to High.Jul 18 2016, 4:25 AM

@Xqt @jayvdb : Is this broken only in compat? Because "Deactivate removeUselessSpaces due to several bugs" commit applied to core too, but there is compat 1.0 in the description at the top of this page

@Xqt This seems solved as in cosmetic_changes there is already a code for this and there seems to be no more problems with nested template regex, right?

Dvorapa changed the task status from Open to Stalled.May 20 2018, 2:09 PM