Page MenuHomePhabricator

Shell Access Request form does not have a watch button
Closed, ResolvedPublic

Description

Details

Reference
bz61104

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:54 AM
bzimport added a project: VPS-Projects.
bzimport set Reference to bz61104.
bzimport added a subscriber: Unknown Object (MLST).

Action "formedit" is provided by the Semantic Forms extension. Thus changing component to "Semantic Forms". If the issue is indeed SWM related this may very well be changed back again.

This was a bug in Semantic Forms, that has since been fixed - if Wikimedia Labs upgrades to the latest version of SF, the problem should go away. Thus, I'm reassigning this to "Wikimedia Labs". :)

Aklapper claimed this task.
Aklapper subscribed.

This was a bug in Semantic Forms, that has since been fixed - if Wikimedia Labs upgrades to the latest version of SF, the problem should go away.

wikitech is now running Semantic Forms 3.2 (ab27659) from March 2015 so I assume this has been fixed.

It still doesn't work for me; I just edited https://wikitech.wikimedia.org/wiki/Shell_Request/Hchuying via https://wikitech.wikimedia.org/w/index.php?title=Shell_Request/Hchuying&action=formedit, and the change did not add the page to my watchlist. @Yaron_Koren, is this an error in "Semantic Forms 3.2 (ab27659) 2015-03-26T23:40:24"?

scfc raised the priority of this task from Low to Needs Triage.
scfc updated the task description. (Show Details)
scfc edited projects, added MediaWiki-extensions-Page_Forms; removed VPS-Projects.
scfc set Security to None.

@scfc - I just looked at the form being used, here:

https://wikitech.wikimedia.org/w/index.php?title=Form:Shell_Access_Request/Edit&action=edit

The issue is that the form doesn't have a "Watch this page" checkbox. You don't automatically have a page added to your watchlist just by editing it with a form - you do need to click that checkbox, if it's there, which it isn't here. Someone just needs to add it to the form definition.

(By the way, it's strange that there are two different forms defined for shell access requests, one "regular" and one "edit" (?) - but that's another story.)

Yaron_Koren renamed this task from "Edit with form" doesn't put page on watchlist (already fixed in Semantic Forms) to "Shell Access Request/Edit" form on Wikitech Labs lacks a "watch this page" checkbox.Oct 14 2015, 6:25 PM

Anybody having an idea which codebase this task is actually about?
SemanticForms got removed and it's not wikitech.wikimedia.org either.
(Also wondering where the "Shell Access Request" process is actually documented.)

Krenair renamed this task from "Shell Access Request/Edit" form on Wikitech Labs lacks a "watch this page" checkbox to Update Semantic Forms.Oct 14 2015, 7:39 PM

I also don't think the name change for this bug is correct - SF is at its latest version, 3.4. Unless that was just done.

chasemp subscribed.

Yeah, SemanticForms is deployed from master like normal extensions...

Oh right, I made that change. Umm...

Krenair renamed this task from Update Semantic Forms to Shell Access Request form does not have a watch button.Feb 14 2016, 2:31 AM
Krenair removed a subscriber: wikibugs-l-list.