Page MenuHomePhabricator
Create Task
Maniphest T63152

VisualEditor: Selecting "None" as position in Media Settings>Advanced Settings shifts the image to the right of the page
Closed, DeclinedPublic
Actions

Description

Screenshot

Steps to reproduce:

1.Open a page with VE
2.Insert an image
3.Go to Media Settings>Advanced Settings for the image
4.Select the value "None" under the postion

Observed Result:
Selecting "None" as position in Media Settings>Advanced Settings shifts the image to the right of the page

See the screenshot attached.
Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65
OS: MAC OS X 10. 8. 5
Page:http://en.wikipedia.beta.wmflabs.org/wiki/10thFeb

Version: unspecified
Severity: normal

Attached:

Screen_Shot_2014-02-10_at_11.41.31_AM.png (534×1 px, 103 KB)

Details

Reference
bz61152

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:57 AM
• bzimport added a project: VisualEditor-EditingTools.
• bzimport set Reference to bz61152.
Ryasmeen created this task.Feb 10 2014, 7:45 PM
Ryasmeen added a comment.Feb 10 2014, 7:49 PM

After that , Selecting Right moves the image to the left

Mooeypoo added a comment.Feb 11 2014, 9:46 PM

I can't manage to replicate this bug in master. "None" shifts the image to the left in an English wiki, and right in an RTL wiki (Hebrew on my local machine)

That said, this fix changes the behavior of the position widget. I tested it under that commit as well and couldn't replicate in both Chrome and Firefox.

https://gerrit.wikimedia.org/r/#/c/112041/

Mooeypoo added a comment.Feb 11 2014, 10:49 PM

When I try this in betalabs, the image shifts to the left of the page when I select "None", as expected.

There is, however, another bug where the image doesn't have an *initial* position visible in the editor. That is fixed in the upcoming commit that I mentioned above.

Jdforrester-WMF added a comment.Mar 20 2014, 10:28 PM

Think this is OK now?

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:08 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL