Page MenuHomePhabricator

ToS can overflow flow-post-form-controls row
Closed, DeclinedPublic

Description

Terms of Service overhangs collapse icons

In both Firefox and Chromium, if I create a new topic, the Terms of Service is taller than the Cancel [Preview] [Add topic] row of buttons. I think as a result it overhangs the trio of Collapse view icons immediately following, and more seriously if there's an error posting then it overlaps the error box. See attachments. One fix is for the flow-post-form-controls div should be as large as its children, another might be to have a clear-both div following. Careful, I think the current CSS evolved from trying to fix other layout bugs.


Version: master
Severity: normal

Attached:

2014-02-10_ToS_overlaps_collapse_row.png (88×753 px, 12 KB)

Details

Reference
bz61168

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:58 AM
bzimport set Reference to bz61168.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 14552
Terms of Service overlaps Add topic error box

The funny layout of the first line of the errorbox is the 50%-wide ToS aligning right and pushing it over.

Attached:

2014-02-10_Flow_errorbox_overlap.png (179×759 px, 22 KB)

We should probably add ui-helper-clearfix around the topic (and other places where this may occur) container

Doesn't seem applicable post rewrite of front end.