russblau wrote:

A little further testing shows that, when starting Python from the command prompt, WindowsError is still undefined (not too surprising, since this is a Linux machine), but evidently importing pywikibot in this configuration does not hit the try/except block on line 134 of version.py

We can either replace it by OSError, or add

try:

WindowsError

except NameError:

class WindowError(OSError):
    pass

somewhere on top (or in pywikibot.exceptions?)

russblau wrote:

I'd vote for OSError as more general. If you wanted to go the latter route, it would have to be in version.py; putting it in any other module would not work because of namespace issues.

• Bug 61816 has been marked as a duplicate of this bug. ***

Change 114988 had a related patch set uploaded by Merlijn van Deen:
(bug 61231) use OSError as WindowsError does not exist on unix hosts

https://gerrit.wikimedia.org/r/114988

Change 114988 merged by jenkins-bot:
(bug 61231) use OSError as WindowsError does not exist on unix hosts

https://gerrit.wikimedia.org/r/114988

russblau wrote:

This just leads to a new error:

/usr/lib/python2.7/subprocess.py in _execute_child(self=<subprocess.Popen object>, args=['git.cmd', '--no-pager', 'log', '-1', '--pretty=format:"%ad|%an|%h|%H|%d"--abbrev-commit', '--date=iso'], executable='git.cmd', preexec_fn=None, close_fds=False, cwd='/shared/pywikipedia/rewrite', env=None, universal_newlines=False, startupinfo=None, creationflags=0, shell=False, p2cread=None, p2cwrite=None, c2pread=8, c2pwrite=9, errread=None, errwrite=None)

1247                     if fd is not None:
1248                         os.close(fd)

> 1249 raise child_exception

1250 
1251

child_exception = OSError(2, 'No such file or directory')

<type 'exceptions.OSError'>: [Errno 2] No such file or directory

args = (2, 'No such file or directory') 
child_traceback = 'Traceback (most recent call last):\n File "/usr/...st)\nOSError: [Errno 2] No such file or directory\n' 
errno = 2 
filename = None 
message = '' 
strerror = 'No such file or directory'

Basically, getversiondict() needs to be able to fail gracefully and return some kind of placeholder value if it isn't able to locate either a GIT or SVN version number, rather than throw an exception and stop the entire framework from executing.

@Russell Blau: This is irrelevant to this bug. It's about tools lab. Normally this problem would not occur because /usr/bin is in $PATH, so calling "git" has no problem. However, in tools web server, /usr/bin is not in $PATH. merely calling git therefore is not enough; we have to call /usr/bin/git.

Do you think tools lab needs to reconfigure? I asked someone in IRC, and he said like don't solve the problem with $PATH.

Closing again as per comment 8, as the original bug reported in *this* report is fixed.

Well, I mean my comment is unrelated to the bug, not his comment. Anyway, since Merjin van Deen has filed another bug separately already, let's follow the other bug instead.

I have this problem again, WindowsError when running in UNIX from cron (git is not on $PATH):

Traceback (most recent call last):
  File "/home/saper/wikipedia/src/meta/kursy/tabelac.py", line 8, in <module>
    import wikipedia
  File "/home/saper/wikipedia/compat/wikipedia.py", line 6062, in <module>
    versionrev=(version.getversiondict()["rev"])
  File "/home/saper/wikipedia/compat/pywikibot/version.py", line 70, in getversiondict
    (tag, rev, date, hsh) = getversion_git(_program_dir)
  File "/home/saper/wikipedia/compat/pywikibot/version.py", line 181, in getversion_git
    except WindowsError:
NameError: global name 'WindowsError' is not defined

This is an error in Pywikibot-compat btw.

Change 208839 had a related patch set uploaded (by saper):
(bug T63231) use OSError as WindowsError does not exist on unix hosts

https://gerrit.wikimedia.org/r/208839

Change 208839 merged by saper:
(bug T63231) use OSError as WindowsError does not exist on unix hosts

https://gerrit.wikimedia.org/r/208839