Page MenuHomePhabricator

Flow: browser tests Action menu problem
Closed, ResolvedPublic

Description

Browser tests are sometimes failing waiting for actions to appear, e.g.
https://saucelabs.com/jobs/4af26fb0dae64f68afbb6e50aa5c2254 failed with

Create new topic logged in "timed out after 5 seconds, waiting for {:css=>"div.tipsy-inner input.flow-hide-topic-link"} to become present (Watir::Wait::TimeoutError)",

and locally tests failed with

Then I should see a Hide button    # features/step_definitions/flow_steps.rb:104
timed out after 5 seconds, waiting for {:css=>"div.tipsy-inner input.flow-hide-post-link"} to become present (Watir::Wait::TimeoutError)
features/flow_logged_in.feature:30:in `Then I should see a Hide button'

In both cases an action menu appears but it's the wrong one.

The prior step is "When I click the Topic Actions link" or "And I click Actions", and in flow_pager.rb, the topic_actions_link and actions_link page elements are both just text: "Actions". So the browser might click the wrong actions item; it's complicated by the topic_index/action_index variable that points Firefox and Chrome at different topics and posts.

I think the topic_actions_link and actions_link page elements need to target the right actions button, e.g. with

css ".flow-topic-title" text "Actions"

and

css ".flow-post-container" text "Actions"

Version: master
Severity: normal

Details

Reference
bz61247

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:03 AM
bzimport set Reference to bz61247.
bzimport added a subscriber: Unknown Object (MLST).

Change 112858 had a related patch set uploaded by Spage:
Specify which Actions menu, Topic or Post

https://gerrit.wikimedia.org/r/112858

Change 112858 merged by Cmcmahon:
Specify which Actions menu, Topic or Post

https://gerrit.wikimedia.org/r/112858