Page MenuHomePhabricator

Fatal error: applying cross-wiki user rights broken (seemingly following rollout of 1.23wmf13)
Closed, ResolvedPublic

Description

When at [[m:Special:UserRights]] trying to apply xwiki rights (as a steward) and it fails, generating a FATAL ERROR screen

PHP fatal error in /usr/local/apache/common-local/php-1.23wmf13/includes/specials/SpecialUserrights.php line 155:
Call to undefined method UserRightsProxy::clearInstanceCache()

Stewards are therefore unable to change any rights crosswiki.

I was unsuccessful to apply rights changes to idwikibooks (different rights tried), mediawiki, afwiki. This is wmf12 and wmf13 renditions, so it doesn't seem to be at the receiving end.

I can successfully change local rights at meta, so it does not seem to be internal to a wiki.


Version: wmf-deployment
Severity: critical

Details

Reference
bz61252

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 3:03 AM
bzimport set Reference to bz61252.

#0 /usr/local/apache/common-local/php-1.23wmf13/includes/specials/SpecialUserrights.php(155): UserrightsPage->execute()
#1 /usr/local/apache/common-local/php-1.23wmf13/includes/specialpage/SpecialPage.php(374): UserrightsPage->execute(NULL)
#2 /usr/local/apache/common-local/php-1.23wmf13/includes/specialpage/SpecialPageFactory.php(489): SpecialPage->run(NULL)
#3 /usr/local/apache/common-local/php-1.23wmf13/includes/Wiki.php(285): SpecialPageFactory::executePath(Object(Title), Object(RequestContext))
#4 /usr/local/apache/common-local/php-1.23wmf13/includes/Wiki.php(586): MediaWiki->performRequest()
#5 /usr/local/apache/common-local/php-1.23wmf13/includes/Wiki.php(447): MediaWiki->main()
#6 /usr/local/apache/common-local/php-1.23wmf13/index.php(49): MediaWiki->run()
#7 /usr/local/apache/common-local/w/index.php(3): require('/usr/local/apac...')
#8 {main}

Change 112847 had a related patch set uploaded by Legoktm:
Only call ->clearInstanceCache() if $targetUser instanceof User

https://gerrit.wikimedia.org/r/112847

Change 112848 had a related patch set uploaded by Tim Starling:
Only call ->clearInstanceCache() if $targetUser instanceof User

https://gerrit.wikimedia.org/r/112848

Change 112847 merged by jenkins-bot:
Only call ->clearInstanceCache() if $targetUser instanceof User

https://gerrit.wikimedia.org/r/112847

Change 112848 merged by jenkins-bot:
Only call ->clearInstanceCache() if $targetUser instanceof User

https://gerrit.wikimedia.org/r/112848

Deployed by Tim, and verified by billinghurst that it was working again.