Page MenuHomePhabricator

Prettify default theme/skin of mailman's listinfo pages
Closed, ResolvedPublic

Description

Pages such as https://lists.wikimedia.org/mailman/listinfo/wikimedia-l are currently super-ugly. We've discussed redesigning these pages, but these discussions seem to have fallen apart without action and I can't find a relevant bug report tracking this issue.


Version: wmf-deployment
Severity: enhancement
Whiteboard: theme skin

Details

Reference
bz61283

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:05 AM
bzimport set Reference to bz61283.

[[mailarchive:wikimedia-l/2013-April/125188.html]]

:) nicest listinfo page i have seen so far i think:) nice! i always like to point out each list admin can do this for "their" list as well

Daniel: Can we change the default in our mailman installation? I imagine there's a template file somewhere that could be tweaked.

Thehelpfulonewiki wrote:

I remember working on this with Quim - the source is at https://github.com/quimgil/mailman-templates I believe. The problem is there's a tweak in the default file for the newer version of Mailman IIRC - so I suggested that we get that upgraded first /before/ we make these tweaks.

The first step to that would be upgrading sodium from lucid to precise which is https://rt.wikimedia.org/Ticket/Display.html?id=5420 (and has been waiting since July 2013!)

(In reply to Thehelpfulone from comment #5)

Any status update?

Thehelpfulonewiki wrote:

(In reply to MZMcBride from comment #6)

(In reply to Thehelpfulone from comment #5)

Any status update?

Last I checked I was waiting for ops to upgrade sodium which would include a mailman update where the default listinfo template was changed. That way we could make sure the design works after installation of an update rather than doing it now then updating and potentially things breaking. Still waiting for an upgrade though!

Spent the past two hours or so working with Thehelpfulone on this. We've got something. Gerrit patch coming shortly. It needs to be translated by our community as it is Wikimedia specific. Currently (as of writing) only English and Dutch is supported.

Change 154964 had a related patch set uploaded by John F. Lewis:
mailman: use a new default theme (prettier mailman)

https://gerrit.wikimedia.org/r/154964

(In reply to John F. Lewis from comment #8)

It needs to be translated by our community as it is Wikimedia specific.

What is the recommended process for translators to get the English text and submit the translations?

Thehelpfulonewiki wrote:

On the most up-to-date version https://mailman.wmflabs.org/mailman/listinfo/test there's a 'Translate page' link on the side bar which links to https://meta.wikimedia.org/wiki/Mailing_lists/List_info on Meta where translations can be submitted.

And are manually being shoved into Gerrit by me (I am in the process of adding about 15 which were translated over night)

It would be useful if the patch linked mailman docs on how changing default templates works. For instance, how does it handle language fallback? If it doesn't, are you planning to push that patch only if/when it has more translations than the default template?

(In reply to John F. Lewis from comment #12)

And are manually being shoved into Gerrit by me (I am in the process of
adding about 15 which were translated over night)

Sigh; thanks for the work. FWIW, the (horrible) script used by Fundraising for this (horrible) unsupported workflow seems to be https://git.wikimedia.org/blob/wikimedia%2Ffundraising%2Fcrm/HEAD/sites%2Fall%2Fmodules%2Fthank_you%2Fgenerators%2FRenderTranslatedPage.php

(In reply to Nemo from comment #13)

It would be useful if the patch linked mailman docs on how changing default
templates works. For instance, how does it handle language fallback? If it
doesn't, are you planning to push that patch only if/when it has more
translations than the default template?

Language fall back currently is; Does the list's language/the selected language exist? Yes - Display it. No - Fall back to SEVER_LANGUAGE (English for us). We are pushing for every language we have enabled at the minute to have a translation for the theme. A few key parts such as subscribing etc. are default Mailman i18n so they will not be affected.

All languages have their own 'listinfo' so ultimately; we can push the patch and all languages we specified will have this theme while languages such as big5, will still use the old theme. This behaviour can be changed but is a lot of work of work and pointless to replace them with English templates.

Change 154964 merged by Andrew Bogott:
mailman: use a new default theme (prettier mailman)

https://gerrit.wikimedia.org/r/154964

Merged. I'll mark this as verified once Puppet updates Sodium :)

Well, this is beautiful. Thank you all for pursuing this task until the end!